github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-12 05:21:58 +00:00
Code Issues Projects Releases Wiki Activity

scheduler_perf: shut down apiserver clients before apiserver

Browse Source 
The cancellation of the context happened after the cleanup of the apiserver, so
clients using that context were kept running. That wasn't the intent and causes
a slow shutdown because the apiserver delays its shutdown when it has active
clients.

The fix is to create a new cancellation context and to use that for the
clients. The automatic cancellation of it then happens before the apiserver
cleanup.
This commit is contained in:
Patrick Ohly 2024-06-04 16:58:54 +02:00
parent ff5b5f9b2c
commit 246e2aedf5
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/integration/scheduler_perf/util.go
View File

@ -98,11 +98,10 @@ func mustSetupCluster(tCtx ktesting.TContext, config *config.KubeSchedulerConfig
if err != nil {
tCtx.Fatalf("start apiserver: %v", err)
}
// Cleanup will be in reverse order: first the clients by canceling the
// child context (happens automatically), then the server.
tCtx.Cleanup(server.TearDownFn)
// Cleanup will be in reverse order: first the clients get cancelled,
// then the apiserver is torn down via the automatic cancelation of
// tCtx.
tCtx = ktesting.WithCancel(tCtx)
// TODO: client connection configuration, such as QPS or Burst is configurable in theory, this could be derived from the `config`, need to
// support this when there is any testcase that depends on such configuration.