github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-07-17 20:00:07 +00:00
Code Issues Projects Releases Wiki Activity

Add test coverage to ensure that when PLR are checkpointed, overhead is excluded from it. And when mapping allocated resources back from the checkpoint to pod spec the values have resources excluding the overhead

Browse Source
This commit is contained in:
ndixita
2026-03-12 20:06:58 +00:00
parent 03e8d88396
commit 27b99fe2ae
1 changed files with 32 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
pkg/kubelet/allocation/allocation_manager_test.go
View File

@@ -158,7 +158,15 @@ func TestUpdatePodFromAllocation(t *testing.T) {
v1.ResourceMemory: *resource.NewQuantity(2500, resource.DecimalSI),
},
}
podWithPodLevelResourcesAndOverhead := podWithPodLevelResources.DeepCopy()
podWithPodLevelResourcesAndOverhead.Spec.Overhead = v1.ResourceList{
v1.ResourceCPU: *resource.NewMilliQuantity(100, resource.DecimalSI),
v1.ResourceMemory: *resource.NewQuantity(200, resource.DecimalSI),
}
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.NodeDeclaredFeatures, true)
tests := []struct {
name string
pod *v1.Pod
@@ -250,6 +258,14 @@ func TestUpdatePodFromAllocation(t *testing.T) {
expectUpdate: true,
expectPod: resizedPodWithPodLevelResources,
inPlacePodLevelResizeEnabled: true,
}, {
name: "pod-level resources with overhead, checkpoint matches spec (no overhead stored)",
pod: podWithPodLevelResourcesAndOverhead,
allocated: state.PodResourceInfo{
PodLevelResources: podWithPodLevelResourcesAndOverhead.Spec.Resources.DeepCopy(),
},
expectUpdate: false,
inPlacePodLevelResizeEnabled: true,
}, {
name: "resized pod-level resources with feature gate disabled",
pod: podWithPodLevelResources,
@@ -1522,6 +1538,11 @@ func TestAllocationManagerAddPodWithPLR(t *testing.T) {
pod1SmallWithPLR := pod1Small.DeepCopy()
pod1SmallWithPLR.Spec.Resources = &v1.ResourceRequirements{Requests: cpu1Mem1G}
pod1SmallWithPLRAndOverhead := pod1SmallWithPLR.DeepCopy()
pod1SmallWithPLRAndOverhead.Spec.Overhead = v1.ResourceList{
v1.ResourceCPU: resource.MustParse("100m"),
v1.ResourceMemory: resource.MustParse("200Mi"),
}
pod1LargeWithPLR := pod1Large.DeepCopy()
pod1LargeWithPLR.Spec.Resources = &v1.ResourceRequirements{Requests: cpu2Mem2G}
pod2SmallWithPLR := pod2Small.DeepCopy()
@@ -1557,6 +1578,17 @@ func TestAllocationManagerAddPodWithPLR(t *testing.T) {
expectedAllocatedResourcesState: map[types.UID]resourceState{pod1UID: {podResources: cpu1Mem1G, containerResources: cpu1Mem1G}},
ipprPLRFeatureGate: true,
},
{
name: "PLR IPPR Enabled - New pod with overhead admitted and allocated resources updated without overhead",
initialAllocatedResourcesState: map[types.UID]resourceState{},
currentActivePods: []*v1.Pod{},
podToAdd: pod1SmallWithPLRAndOverhead,
admitFunc: nil,
expectAdmit: true,
// allocated resources updated with pod1's resources, excluding overhead
expectedAllocatedResourcesState: map[types.UID]resourceState{pod1UID: {podResources: cpu1Mem1G, containerResources: cpu1Mem1G}},
ipprPLRFeatureGate: true,
},
{
name: "PLR IPPR Disabled - New pod admitted with PLR but allocated pod-level resources not updated",
initialAllocatedResourcesState: map[types.UID]resourceState{},