github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-07-23 10:26:22 +00:00
Code Issues Projects Releases Wiki Activity

feat: skip validation for types that are Lists in GetTargets function

Browse Source
This commit is contained in:
yongruilin
2026-01-06 19:50:42 +00:00
parent a1d638ea11
commit 2a4951be27
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
staging/src/k8s.io/code-generator/cmd/validation-gen/targets.go
View File

@@ -48,8 +48,10 @@ const (
)
var (
runtimePkg = "k8s.io/apimachinery/pkg/runtime"
schemeType = types.Name{Package: runtimePkg, Name: "Scheme"}
runtimePkg = "k8s.io/apimachinery/pkg/runtime"
schemeType = types.Name{Package: runtimePkg, Name: "Scheme"}
metav1Pkg = "k8s.io/apimachinery/pkg/apis/meta/v1"
listMetaType = types.Name{Package: metav1Pkg, Name: "ListMeta"}
)
func extractTag(comments []string) ([]string, bool) {
@@ -319,6 +321,16 @@ func GetTargets(context *generator.Context, args *Args) []generator.Target {
if checkTag(t.SecondClosestCommentLines, "true") {
return true
}
// skip types that embed metav1.ListMeta
if t.Kind == types.Struct {
for _, member := range t.Members {
if member.Embedded && member.Type.Name == listMetaType {
return false
}
}
}
// all types
for _, v := range typesWith {
if v == "*" && !namer.IsPrivateGoName(t.Name.Name) {