mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-24 12:15:52 +00:00
Merge pull request #50306 from yastij/servicecontroller-simplify-existenceCheck
Automatic merge from submit-queue (batch tested with PRs 50306, 49624) simplify logic around LB deletion for servicecontroller **What this PR does / why we need it**: simplify logic around LB deletio **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: discovered when aswering to #50299 **Release note**: ```release-note None ```
This commit is contained in:
commit
2c56b1c9a0
@ -261,16 +261,11 @@ func (s *ServiceController) createLoadBalancerIfNeeded(key string, service *v1.S
|
||||
var err error
|
||||
|
||||
if !wantsLoadBalancer(service) {
|
||||
needDelete := true
|
||||
_, exists, err := s.balancer.GetLoadBalancer(s.clusterName, service)
|
||||
if err != nil {
|
||||
return fmt.Errorf("Error getting LB for service %s: %v", key, err), retryable
|
||||
}
|
||||
if !exists {
|
||||
needDelete = false
|
||||
}
|
||||
|
||||
if needDelete {
|
||||
if exists {
|
||||
glog.Infof("Deleting existing load balancer for service %s that no longer needs a load balancer.", key)
|
||||
s.eventRecorder.Event(service, v1.EventTypeNormal, "DeletingLoadBalancer", "Deleting load balancer")
|
||||
if err := s.balancer.EnsureLoadBalancerDeleted(s.clusterName, service); err != nil {
|
||||
|
Loading…
Reference in New Issue
Block a user