mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-24 12:15:52 +00:00
Merge pull request #19714 from jlowdermilk/pr-workflow
Auto commit by PR queue bot
This commit is contained in:
commit
3124474458
BIN
docs/devel/pr_workflow.dia
Normal file
BIN
docs/devel/pr_workflow.dia
Normal file
Binary file not shown.
BIN
docs/devel/pr_workflow.png
Normal file
BIN
docs/devel/pr_workflow.png
Normal file
Binary file not shown.
After Width: | Height: | Size: 79 KiB |
@ -34,19 +34,9 @@ Documentation for other releases can be found at
|
||||
Pull Request Process
|
||||
====================
|
||||
|
||||
An overview of how we will manage old or out-of-date pull requests.
|
||||
|
||||
Process
|
||||
-------
|
||||
|
||||
We will close any pull requests older than two weeks.
|
||||
|
||||
Exceptions can be made for PRs that have active review comments, or that are awaiting other dependent PRs. Closed pull requests are easy to recreate, and little work is lost by closing a pull request that subsequently needs to be reopened.
|
||||
|
||||
We want to limit the total number of PRs in flight to:
|
||||
* Maintain a clean project
|
||||
* Remove old PRs that would be difficult to rebase as the underlying code has changed over time
|
||||
* Encourage code velocity
|
||||
An overview of how pull requests are managed for kubernetes. This document
|
||||
assumes the reader has already followed the [development guide](development.md)
|
||||
to set up their environment.
|
||||
|
||||
Life of a Pull Request
|
||||
----------------------
|
||||
@ -58,10 +48,40 @@ Either the [on call](on-call-rotations.md) manually or the [github "munger"](htt
|
||||
There are several requirements for the submit-queue to work:
|
||||
* Author must have signed CLA ("cla: yes" label added to PR)
|
||||
* No changes can be made since last lgtm label was applied
|
||||
* k8s-bot must have reported the GCE E2E build and test steps passed (Travis, Shippable and Jenkins build)
|
||||
* k8s-bot must have reported the GCE E2E build and test steps passed (Travis, Jenkins unit/integration, Jenkins e2e)
|
||||
|
||||
Additionally, for infrequent or new contributors, we require the on call to apply the "ok-to-merge" label manually. This is gated by the [whitelist](https://github.com/kubernetes/contrib/blob/master/mungegithub/whitelist.txt).
|
||||
|
||||
### Before sending a pull request
|
||||
|
||||
The following will save time for both you and your reviewer:
|
||||
|
||||
* Enable [pre-commit hooks](development.md#committing-changes-to-your-fork) and verify they pass.
|
||||
* Verify `hack/verify-generated-docs.sh` passes.
|
||||
* Verify `hack/test-go.sh` passes.
|
||||
|
||||
### Visual overview
|
||||
|
||||

|
||||
|
||||
Other notes
|
||||
-----------
|
||||
|
||||
Pull requests that are purely support questions will be closed and
|
||||
redirected to [stackoverflow](http://stackoverflow.com/questions/tagged/kubernetes).
|
||||
We do this to consolidate help/support questions into a single channel,
|
||||
improve efficiency in responding to requests and make FAQs easier
|
||||
to find.
|
||||
|
||||
Pull requests older than 2 weeks will be closed. Exceptions can be made
|
||||
for PRs that have active review comments, or that are awaiting other dependent PRs.
|
||||
Closed pull requests are easy to recreate, and little work is lost by closing a pull
|
||||
request that subsequently needs to be reopened. We want to limit the total number of PRs in flight to:
|
||||
* Maintain a clean project
|
||||
* Remove old PRs that would be difficult to rebase as the underlying code has changed over time
|
||||
* Encourage code velocity
|
||||
|
||||
|
||||
Automation
|
||||
----------
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user