github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-30 15:05:27 +00:00
Code Issues Projects Releases Wiki Activity

Fix an unreachable kubectl explain field lookup test

Browse Source 
In error case, the condition “gotErr != test.err && gotPath !=
test.expectedPath” never fulfill because in this case both gotPath and
test.expectedPath always an empty string. So the err “err:  `field "what?"
does not exist`” doesn’t get tasted. For example, if you change the value of
“err” to anything, the test still will pass. Also, since gotPath is empty
string in case of err, in the output error we probably don’t want to display
path.
This commit is contained in:
Sahdev P. Zala 2017-11-07 20:33:03 -05:00
parent 210626577b
commit 32d8fa0058
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/kubectl/explain/field_lookup_test.go
View File

@ -69,9 +69,9 @@ func TestFindField(t *testing.T) {
gotPath = path.GetPath().String()
}
if gotErr != test.err && gotPath != test.expectedPath {
t.Errorf("LookupSchemaForField(schema, %v) = (%v, %v), expected (%s, %v)",
test.path, gotErr, gotPath, test.expectedPath, test.err)
if gotErr != test.err || gotPath != test.expectedPath {
t.Errorf("LookupSchemaForField(schema, %v) = (path: %q, err: %q), expected (path: %q, err: %q)",
test.path, gotPath, gotErr, test.expectedPath, test.err)
}
}
}