Merge pull request #88450 from shikanon/fix/golintTypo

fix typos error in handlers_test.go file
This commit is contained in:
Kubernetes Prow Robot 2020-03-18 14:24:44 -07:00 committed by GitHub
commit 34ad7d1984
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -133,8 +133,8 @@ func (f *fakeHTTP) Get(url string) (*http.Response, error) {
}
func TestRunHandlerHttp(t *testing.T) {
fakeHttp := fakeHTTP{}
handlerRunner := NewHandlerRunner(&fakeHttp, &fakeContainerCommandRunner{}, nil)
fakeHTTPGetter := fakeHTTP{}
handlerRunner := NewHandlerRunner(&fakeHTTPGetter, &fakeContainerCommandRunner{}, nil)
containerID := kubecontainer.ContainerID{Type: "test", ID: "abc1234"}
containerName := "containerFoo"
@ -160,8 +160,8 @@ func TestRunHandlerHttp(t *testing.T) {
if err != nil {
t.Errorf("unexpected error: %v", err)
}
if fakeHttp.url != "http://foo:8080/bar" {
t.Errorf("unexpected url: %s", fakeHttp.url)
if fakeHTTPGetter.url != "http://foo:8080/bar" {
t.Errorf("unexpected url: %s", fakeHTTPGetter.url)
}
}
@ -227,8 +227,8 @@ func TestRunHandlerHttpFailure(t *testing.T) {
expectedResp := http.Response{
Body: ioutil.NopCloser(strings.NewReader(expectedErr.Error())),
}
fakeHttp := fakeHTTP{err: expectedErr, resp: &expectedResp}
handlerRunner := NewHandlerRunner(&fakeHttp, &fakeContainerCommandRunner{}, nil)
fakeHTTPGetter := fakeHTTP{err: expectedErr, resp: &expectedResp}
handlerRunner := NewHandlerRunner(&fakeHTTPGetter, &fakeContainerCommandRunner{}, nil)
containerName := "containerFoo"
containerID := kubecontainer.ContainerID{Type: "test", ID: "abc1234"}
container := v1.Container{
@ -255,7 +255,7 @@ func TestRunHandlerHttpFailure(t *testing.T) {
if msg != expectedErrMsg {
t.Errorf("unexpected error message: %q; expected %q", msg, expectedErrMsg)
}
if fakeHttp.url != "http://foo:8080/bar" {
t.Errorf("unexpected url: %s", fakeHttp.url)
if fakeHTTPGetter.url != "http://foo:8080/bar" {
t.Errorf("unexpected url: %s", fakeHTTPGetter.url)
}
}