github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-22 03:11:40 +00:00
Code Issues Projects Releases Wiki Activity

demote kubelet events test from Conformance

Browse Source 
This test has been part of the Conformance suite since at least
Kubernetes 1.2 (2015-10-xx). Some years later, around 2018-10-xx, we
drafted a rigorous set of rules for tests to follow in order to be
eligible for promotion to Conformance. We explicitly disallowed any
tests that check for specific Events, since they are not an API, and we
make no guarantees about their contents nor their delivery.

Unfortunately, we neglected to go through the existing corpus of
Conformance tests with a fine-toothed comb after drafting these rules.
The very nature of what this test is attempting to exercise and verify
is specific Events, and their delivery, thus making it ineligible for
Conformance. We should have caught and demoted this test back then.

Better late than never?
This commit is contained in:
Aaron Crickenberger 2021-11-17 15:36:28 -08:00
parent 7f756417ff
commit 357ad91d78
2 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/conformance/testdata/conformance.yaml vendored
View File

@ -1788,16 +1788,6 @@
visible at runtime in the container.
release: v1.9
file: test/e2e/common/node/downwardapi.go
- testname: Pod events, verify event from Scheduler and Kubelet
codename: '[sig-node] Events should be sent by kubelets and the scheduler about
pods scheduling and running [Conformance]'
description: Create a Pod, make sure that the Pod can be queried. Create a event
selector for the kind=Pod and the source is the Scheduler. List of the events
MUST be at least one. Create a event selector for kind=Pod and the source is the
Kubelet. List of the events MUST be at least one. Both Scheduler and Kubelet MUST
send events when scheduling and running a Pod.
release: v1.9
file: test/e2e/node/events.go
- testname: init-container-starts-app-restartalways-pod
codename: '[sig-node] InitContainer [NodeConformance] should invoke init containers
on a RestartAlways pod [Conformance]'

7
test/e2e/node/events.go
View File

@ -36,12 +36,7 @@ import (
var _ = SIGDescribe("Events", func() {
f := framework.NewDefaultFramework("events")
/*
Release: v1.9
Testname: Pod events, verify event from Scheduler and Kubelet
Description: Create a Pod, make sure that the Pod can be queried. Create a event selector for the kind=Pod and the source is the Scheduler. List of the events MUST be at least one. Create a event selector for kind=Pod and the source is the Kubelet. List of the events MUST be at least one. Both Scheduler and Kubelet MUST send events when scheduling and running a Pod.
*/
framework.ConformanceIt("should be sent by kubelets and the scheduler about pods scheduling and running ", func() {
ginkgo.It("should be sent by kubelets and the scheduler about pods scheduling and running ", func() {
podClient := f.ClientSet.CoreV1().Pods(f.Namespace.Name)