github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-01 15:58:37 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #119619 from skitt/intstr-parse-parseint

Browse Source 
Limit intstr.Parse() to 32-bit integer parsing
This commit is contained in:
Kubernetes Prow Robot 2023-09-08 13:04:29 -07:00 committed by GitHub
commit 37cf2638c9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 60 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
staging/src/k8s.io/apimachinery/pkg/util/intstr/intstr_test.go
View File

@ -264,3 +264,63 @@ func TestGetValueFromIntOrPercentNil(t *testing.T) {
t.Errorf("expected error got none")
}
}
func TestParse(t *testing.T) {
tests := []struct {
input string
output IntOrString
}{
{
input: "0",
output: IntOrString{Type: Int, IntVal: 0},
},
{
input: "2147483647", // math.MaxInt32
output: IntOrString{Type: Int, IntVal: 2147483647},
},
{
input: "-2147483648", // math.MinInt32
output: IntOrString{Type: Int, IntVal: -2147483648},
},
{
input: "2147483648", // math.MaxInt32+1
output: IntOrString{Type: String, StrVal: "2147483648"},
},
{
input: "-2147483649", // math.MinInt32-1
output: IntOrString{Type: String, StrVal: "-2147483649"},
},
{
input: "9223372036854775807", // math.MaxInt64
output: IntOrString{Type: String, StrVal: "9223372036854775807"},
},
{
input: "-9223372036854775808", // math.MinInt64
output: IntOrString{Type: String, StrVal: "-9223372036854775808"},
},
{
input: "9223372036854775808", // math.MaxInt64+1
output: IntOrString{Type: String, StrVal: "9223372036854775808"},
},
{
input: "-9223372036854775809", // math.MinInt64-1
output: IntOrString{Type: String, StrVal: "-9223372036854775809"},
},
}
for i, test := range tests {
t.Logf("test case %d", i)
value := Parse(test.input)
if test.output.Type != value.Type {
t.Errorf("expected type %d (%v), but got %d (%v)", test.output.Type, test.output, value.Type, value)
continue
}
if value.Type == Int && test.output.IntVal != value.IntVal {
t.Errorf("expected int value %d (%v), but got %d (%v)", test.output.IntVal, test.output, value.IntVal, value)
continue
}
if value.Type == String && test.output.StrVal != value.StrVal {
t.Errorf("expected string value %q (%v), but got %q (%v)", test.output.StrVal, test.output, value.StrVal, value)
}
}
}