github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-06 02:34:03 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #120317 from cezarygerard/limit-logging

Browse Source 
service controller: limit logging node names to 20
This commit is contained in:
Kubernetes Prow Robot 2023-09-13 21:56:11 -07:00 committed by GitHub
commit 37e7f7446f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
staging/src/k8s.io/cloud-provider/controllers/service/controller.go
View File

@ -351,6 +351,7 @@ type loadBalancerOperation int
const (
deleteLoadBalancer loadBalancerOperation = iota
ensureLoadBalancer
maxNodeNamesToLog = 20
)
// syncLoadBalancerIfNeeded ensures that service's status is synced up with loadbalancer
@ -678,6 +679,15 @@ func nodeNames(nodes []*v1.Node) sets.String {
return ret
}
func loggableNodeNames(nodes []*v1.Node) []string {
if len(nodes) > maxNodeNamesToLog {
skipped := len(nodes) - maxNodeNamesToLog
names := nodeNames(nodes[:maxNodeNamesToLog]).List()
return append(names, fmt.Sprintf("<%d more>", skipped))
}
return nodeNames(nodes).List()
}
func shouldSyncUpdatedNode(oldNode, newNode *v1.Node) bool {
// Evaluate the individual node exclusion predicate before evaluating the
// compounded result of all predicates. We don't sync changes on the
@ -791,8 +801,8 @@ func (c *Controller) lockedUpdateLoadBalancerHosts(service *v1.Service, hosts []
klog.V(4).Infof("It took %v seconds to update load balancer hosts for service %s/%s", latency, service.Namespace, service.Name)
updateLoadBalancerHostLatency.Observe(latency)
}()
klog.V(2).Infof("Updating backends for load balancer %s/%s with %d nodes: %v", service.Namespace, service.Name, len(hosts), loggableNodeNames(hosts))
klog.V(2).Infof("Updating backends for load balancer %s/%s with node set: %v", service.Namespace, service.Name, nodeNames(hosts))
// This operation doesn't normally take very long (and happens pretty often), so we only record the final event
err := c.balancer.UpdateLoadBalancer(context.TODO(), c.clusterName, service, hosts)
if err == nil {
@ -817,7 +827,7 @@ func (c *Controller) lockedUpdateLoadBalancerHosts(service *v1.Service, hosts []
return nil
}
c.eventRecorder.Eventf(service, v1.EventTypeWarning, "UpdateLoadBalancerFailed", "Error updating load balancer with new hosts %v: %v", nodeNames(hosts), err)
c.eventRecorder.Eventf(service, v1.EventTypeWarning, "UpdateLoadBalancerFailed", "Error updating load balancer with new hosts %v [node names limited, total number of nodes: %d], error: %v", loggableNodeNames(hosts), len(hosts), err)
return err
}