github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-07-18 04:54:54 +00:00
Code Issues Projects Releases Wiki Activity

Fail to generate unsigned min and max for negative values

Browse Source
This commit is contained in:
Tim Hockin
2026-03-10 18:44:24 -07:00
parent 7f90ee0043
commit 383d74ba4f
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
staging/src/k8s.io/code-generator/cmd/validation-gen/validators/common.go
View File

@@ -34,3 +34,12 @@ func rootTypeString(src, dst *types.Type) string {
}
return src.String() + " -> " + dst.String()
}
// isInt returns true if t is a uint type.
func isUnsignedInt(t *types.Type) bool {
switch t {
case types.Uint, types.Uint64, types.Uint32, types.Uint16, types.Byte:
return true
}
return false
}

12
staging/src/k8s.io/code-generator/cmd/validation-gen/validators/limits.go
View File

@@ -226,7 +226,8 @@ func (minimumTagValidator) GetValidations(context Context, tag codetags.Tag) (Va
// This tag can apply to value and pointer fields, as well as typedefs
// (which should never be pointers). We need to check the concrete type.
if t := util.NonPointer(util.NativeType(context.Type)); !types.IsInteger(t) {
t := util.NonPointer(util.NativeType(context.Type))
if !types.IsInteger(t) {
return result, fmt.Errorf("can only be used on integer types (%s)", rootTypeString(context.Type, t))
}
@@ -234,6 +235,9 @@ func (minimumTagValidator) GetValidations(context Context, tag codetags.Tag) (Va
if err != nil {
return result, fmt.Errorf("failed to parse tag payload as int: %w", err)
}
if isUnsignedInt(t) && intVal < 0 {
return result, fmt.Errorf("must be greater than or equal to zero for unsigned types (%s)", rootTypeString(context.Type, t))
}
result.AddFunction(Function(minimumTagName, DefaultFlags, minimumValidator, intVal))
return result, nil
}
@@ -274,7 +278,8 @@ func (maximumTagValidator) GetValidations(context Context, tag codetags.Tag) (Va
// This tag can apply to value and pointer fields, as well as typedefs
// (which should never be pointers). We need to check the concrete type.
if t := util.NonPointer(util.NativeType(context.Type)); !types.IsInteger(t) {
t := util.NonPointer(util.NativeType(context.Type))
if !types.IsInteger(t) {
return result, fmt.Errorf("can only be used on integer types (%s)", rootTypeString(context.Type, t))
}
@@ -282,6 +287,9 @@ func (maximumTagValidator) GetValidations(context Context, tag codetags.Tag) (Va
if err != nil {
return result, fmt.Errorf("failed to parse tag payload as int: %w", err)
}
if isUnsignedInt(t) && intVal < 0 {
return result, fmt.Errorf("must be greater than or equal to zero for unsigned types (%s)", rootTypeString(context.Type, t))
}
result.AddFunction(Function(maximumTagName, DefaultFlags, maximumValidator, intVal))
return result, nil
}