github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 19:56:01 +00:00
Code Issues Projects Releases Wiki Activity

bugfix in util.sh, fix silent hang

Browse Source 
`gcloud preview --help >/dev/null 2>&1` would silently hang if the
 preview component was not installed. Instead, let stderr flow normally.

to reproduce the bug and verify the fix:
1. gcloud components remove preview #answer yes
2. gcloud preview --help >/dev/null 2>&1 #note the hang, ^C
3A. gcloud preview --help >/dev/null #now prompts you to install preview component

the fix also works when run via "kube-up.sh"

alternatively: `gcloud -q preview --help >/dev/null 2>&1` will silently install
 the missing preview component
This commit is contained in:
Chris Hiestand 2015-02-17 01:35:24 -08:00
parent 6f84bdaba8
commit 38aeb72bf7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cluster/gke/util.sh Normal file → Executable file
View File

@ -70,7 +70,7 @@ function test-build-release() {
function verify-prereqs() {
echo "... in verify-prereqs()" >&2
${GCLOUD} preview --help >/dev/null 2>&1 || {
${GCLOUD} preview --help >/dev/null || {
echo "Either the GCLOUD environment variable is wrong, or the 'preview' component"
echo "is not installed. (Fix with 'gcloud components update preview')"
}