github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-11 13:02:14 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #128398 from tenzen-y/remaining-job-tracking-annotation-testing

Browse Source 
Job: Remove JobTrackingFinalizer annotation specific testings
This commit is contained in:
Kubernetes Prow Robot 2025-01-07 06:26:28 +01:00 committed by GitHub
commit 38fab70477
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
pkg/registry/batch/job/strategy_test.go
View File

@ -988,49 +988,6 @@ func TestJobStrategy_ValidateUpdate(t *testing.T) {
{Type: field.ErrorTypeInvalid, Field: "spec.completions"}, {Type: field.ErrorTypeInvalid, Field: "spec.completions"},
}, },
}, },
"preserving tracking annotation": {
job: &batch.Job{
ObjectMeta: metav1.ObjectMeta{
Name: "myjob",
Namespace: metav1.NamespaceDefault,
ResourceVersion: "0",
Annotations: map[string]string{
batch.JobTrackingFinalizer: "",
},
},
Spec: batch.JobSpec{
Selector: validSelector,
Template: validPodTemplateSpec,
ManualSelector: ptr.To(true),
Parallelism: ptr.To[int32](1),
},
},
update: func(job *batch.Job) {
job.Annotations["foo"] = "bar"
},
},
"deleting user annotation": {
job: &batch.Job{
ObjectMeta: metav1.ObjectMeta{
Name: "myjob",
Namespace: metav1.NamespaceDefault,
ResourceVersion: "0",
Annotations: map[string]string{
batch.JobTrackingFinalizer: "",
"foo": "bar",
},
},
Spec: batch.JobSpec{
Selector: validSelector,
Template: validPodTemplateSpec,
ManualSelector: ptr.To(true),
Parallelism: ptr.To[int32](1),
},
},
update: func(job *batch.Job) {
delete(job.Annotations, "foo")
},
},
"updating node selector for unsuspended job disallowed": { "updating node selector for unsuspended job disallowed": {
job: &batch.Job{ job: &batch.Job{
ObjectMeta: metav1.ObjectMeta{ ObjectMeta: metav1.ObjectMeta{