github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 20:53:33 +00:00
Code Issues Projects Releases Wiki Activity

Only check testname for missing

Browse Source
This commit is contained in:
Jefftree 2020-03-09 12:18:28 -07:00
parent 90cd496e72
commit 40d80195f2
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/conformance/walk.go
View File

@ -329,7 +329,7 @@ func commentToConformanceData(comment string) *conformanceData {
descLines = append(descLines, line) descLines = append(descLines, line)
} }
} }
if cd.Release == "" && cd.TestName == "" { if cd.TestName == "" {
return nil return nil
} }

5
test/conformance/walk_test.go
View File

@ -147,9 +147,8 @@ func TestCommentToConformanceData(t *testing.T) {
desc: "No Release or Testname leads to nil", desc: "No Release or Testname leads to nil",
input: "Description: foo", input: "Description: foo",
}, { }, {
desc: "Release but no Testname does not result in nil", desc: "Release but no Testname should result in nil",
input: "Release: v1.1\nDescription: foo", input: "Release: v1.1\nDescription: foo",
expected: &conformanceData{Release: "v1.1", Description: "foo"},
}, { }, {
desc: "Testname but no Release does not result in nil", desc: "Testname but no Release does not result in nil",
input: "Testname: mytest\nDescription: foo", input: "Testname: mytest\nDescription: foo",