Migrate stability level handle functionality overall metrics package

This commit is contained in:
RainbowMango
2019-09-21 11:19:24 +08:00
parent 9ec270804a
commit 4127525e9b
4 changed files with 16 additions and 32 deletions

View File

@@ -34,10 +34,8 @@ type Counter struct {
// However, the object returned will not measure anything unless the collector is first
// registered, since the metric is lazily instantiated.
func NewCounter(opts *CounterOpts) *Counter {
// todo: handle defaulting better
if opts.StabilityLevel == "" {
opts.StabilityLevel = ALPHA
}
opts.StabilityLevel.setDefaults()
kc := &Counter{
CounterOpts: opts,
lazyMetric: lazyMetric{},
@@ -86,10 +84,8 @@ type CounterVec struct {
// However, the object returned will not measure anything unless the collector is first
// registered, since the metric is lazily instantiated.
func NewCounterVec(opts *CounterOpts, labels []string) *CounterVec {
// todo: handle defaulting better
if opts.StabilityLevel == "" {
opts.StabilityLevel = ALPHA
}
opts.StabilityLevel.setDefaults()
cv := &CounterVec{
CounterVec: noopCounterVec,
CounterOpts: opts,

View File

@@ -34,10 +34,8 @@ type Gauge struct {
// However, the object returned will not measure anything unless the collector is first
// registered, since the metric is lazily instantiated.
func NewGauge(opts *GaugeOpts) *Gauge {
// todo: handle defaulting better
if opts.StabilityLevel == "" {
opts.StabilityLevel = ALPHA
}
opts.StabilityLevel.setDefaults()
kc := &Gauge{
GaugeOpts: opts,
lazyMetric: lazyMetric{},
@@ -86,10 +84,8 @@ type GaugeVec struct {
// However, the object returned will not measure anything unless the collector is first
// registered, since the metric is lazily instantiated.
func NewGaugeVec(opts *GaugeOpts, labels []string) *GaugeVec {
// todo: handle defaulting better
if opts.StabilityLevel == "" {
opts.StabilityLevel = ALPHA
}
opts.StabilityLevel.setDefaults()
cv := &GaugeVec{
GaugeVec: noopGaugeVec,
GaugeOpts: opts,

View File

@@ -46,10 +46,8 @@ type Histogram struct {
// NewHistogram returns an object which is Histogram-like. However, nothing
// will be measured until the histogram is registered somewhere.
func NewHistogram(opts *HistogramOpts) *Histogram {
// todo: handle defaulting better
if opts.StabilityLevel == "" {
opts.StabilityLevel = ALPHA
}
opts.StabilityLevel.setDefaults()
h := &Histogram{
HistogramOpts: opts,
lazyMetric: lazyMetric{},
@@ -98,10 +96,8 @@ type HistogramVec struct {
// prometheus.HistogramVec object. However, the object returned will not measure
// anything unless the collector is first registered, since the metric is lazily instantiated.
func NewHistogramVec(opts *HistogramOpts, labels []string) *HistogramVec {
// todo: handle defaulting better
if opts.StabilityLevel == "" {
opts.StabilityLevel = ALPHA
}
opts.StabilityLevel.setDefaults()
v := &HistogramVec{
HistogramVec: noopHistogramVec,
HistogramOpts: opts,

View File

@@ -37,10 +37,8 @@ type Summary struct {
//
// DEPRECATED: as per the metrics overhaul KEP
func NewSummary(opts *SummaryOpts) *Summary {
// todo: handle defaulting better
if opts.StabilityLevel == "" {
opts.StabilityLevel = ALPHA
}
opts.StabilityLevel.setDefaults()
s := &Summary{
SummaryOpts: opts,
lazyMetric: lazyMetric{},
@@ -93,10 +91,8 @@ type SummaryVec struct {
//
// DEPRECATED: as per the metrics overhaul KEP
func NewSummaryVec(opts *SummaryOpts, labels []string) *SummaryVec {
// todo: handle defaulting better
if opts.StabilityLevel == "" {
opts.StabilityLevel = ALPHA
}
opts.StabilityLevel.setDefaults()
v := &SummaryVec{
SummaryOpts: opts,
originalLabels: labels,