mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-22 11:21:47 +00:00
Merge pull request #39098 from ixdy/verify
Automatic merge from submit-queue Disable verify-test-owners.sh and make `go vet` more obvious **What this PR does / why we need it**: I and others keep seeing the verify-test-owners.sh failure and think that's why the PR failed checks. Rather than making verify-test-owners.sh pass with errors, just skip it entirely. Also print out the `go vet` command we're running, to make that failure more obvious. cc @k82cn @saad-ali **Release note**: ```release-note NONE ```
This commit is contained in:
commit
4495af3822
@ -26,6 +26,7 @@ EXCLUDED_CHECKS=(
|
||||
"verify-linkcheck.sh" # runs in separate Jenkins job once per day due to high network usage
|
||||
"verify-govet.sh" # it has a separate make vet target
|
||||
"verify-staging-client-go.sh" # TODO: enable the script after 1.5 code freeze
|
||||
"verify-test-owners.sh" # TODO(rmmh): figure out how to avoid endless conflicts
|
||||
)
|
||||
|
||||
function is-excluded {
|
||||
|
@ -46,4 +46,5 @@ if [[ ${#targets[@]} -eq 0 ]]; then
|
||||
targets=$(go list -e ./... | egrep -v "/(third_party|vendor|staging|clientset_generated)/")
|
||||
fi
|
||||
|
||||
set -x
|
||||
go vet "${goflags[@]:+${goflags[@]}}" ${targets[@]}
|
||||
|
@ -24,6 +24,5 @@ source "${KUBE_ROOT}/hack/lib/init.sh"
|
||||
cd "${KUBE_ROOT}"
|
||||
if ! hack/update_owners.py --check; then
|
||||
echo 'Run ./hack/update_owners.py to fix it'
|
||||
exit # TODO(rmmh): fix Github merging to respect .gitattributes
|
||||
exit 1
|
||||
fi
|
||||
|
Loading…
Reference in New Issue
Block a user