github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-01-06 07:57:35 +00:00
Code Issues Projects Releases Wiki Activity

Comment out calls to httptest.Server.Close()

Browse Source
This commit is contained in:
Wojciech Tyczynski
2016-02-15 12:53:02 +01:00
parent 48caef3576
commit 463d21f352
4 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/integration/metrics_test.go
View File

@@ -86,7 +86,8 @@ func checkForExpectedMetrics(t *testing.T, metrics []*prometheuspb.MetricFamily,
func TestMasterProcessMetrics(t *testing.T) {
_, s := framework.RunAMaster(t)
defer s.Close()
// TODO: Uncomment when fix #19254
// defer s.Close()
metrics, err := scrapeMetrics(s)
if err != nil {
@@ -103,7 +104,8 @@ func TestMasterProcessMetrics(t *testing.T) {
func TestApiserverMetrics(t *testing.T) {
_, s := framework.RunAMaster(t)
defer s.Close()
// TODO: Uncomment when fix #19254
// defer s.Close()
// Make a request to the apiserver to ensure there's at least one data point
// for the metrics we're expecting -- otherwise, they won't be exported.