github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-14 13:45:06 +00:00
Code Issues Projects Releases Wiki Activity

add TODO for image fs

Browse Source
This commit is contained in:
Kevin Hannon
2024-11-01 08:46:55 -04:00
parent 742ca47e72
commit 48dc7d3267
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/kubelet/eviction/eviction_manager.go
View File

@@ -254,12 +254,16 @@ func (m *managerImpl) synchronize(diskInfoProvider DiskInfoProvider, podFunc Act
if m.dedicatedImageFs == nil {
hasImageFs, imageFsErr := diskInfoProvider.HasDedicatedImageFs(ctx)
if imageFsErr != nil {
// TODO: This should be refactored to log an error and retry the HasDedicatedImageFs
// If we have a transient error this will never be retried and we will not set eviction signals
klog.ErrorS(imageFsErr, "Eviction manager: failed to get HasDedicatedImageFs")
return nil, fmt.Errorf("eviction manager: failed to get HasDedicatedImageFs: %w", imageFsErr)
}
m.dedicatedImageFs = &hasImageFs
splitContainerImageFs, splitErr := diskInfoProvider.HasDedicatedContainerFs(ctx)
if splitErr != nil {
// A common error case is when there is no split filesystem
// there is an error finding the split filesystem label and we want to ignore these errors
klog.ErrorS(splitErr, "eviction manager: failed to check if we have separate container filesystem. Ignoring.")
}