github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-30 15:05:27 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #112944 from kishen-v/fix_test_failures_go_1_20

Browse Source 
Switch to assert.ErrorEquals from assert.Equal to check error equality
This commit is contained in:
Kubernetes Prow Robot 2022-10-12 06:23:00 -07:00 committed by GitHub
commit 4f2faa2f1c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
staging/src/k8s.io/legacy-cloud-providers/azure/azure_blobDiskController_test.go
View File

@ -88,7 +88,7 @@ func TestCreateVolume(t *testing.T) {
diskName, diskURI, requestGB, err := b.CreateVolume("testBlob", "testsa", "type", b.common.location, 10)
expectedErr := fmt.Errorf("could not get storage key for storage account testsa: could not get storage key for "+
"storage account testsa: Retriable: false, RetryAfter: 0s, HTTPStatusCode: 500, RawError: %w", error(nil))
assert.Equal(t, expectedErr, err)
assert.EqualError(t, err, expectedErr.Error())
assert.Empty(t, diskName)
assert.Empty(t, diskURI)
assert.Zero(t, requestGB)
@ -124,10 +124,10 @@ func TestDeleteVolume(t *testing.T) {
diskURL := "https://foo.blob./vhds/bar.vhd"
err := b.DeleteVolume(diskURL)
expectedErr := fmt.Errorf("no key for storage account foo, err Retriable: false, RetryAfter: 0s, HTTPStatusCode: 500, RawError: %w", error(nil))
assert.Equal(t, expectedErr, err)
assert.EqualError(t, err, expectedErr.Error())
err = b.DeleteVolume(diskURL)
assert.Equal(t, expectedErr, err)
assert.EqualError(t, err, expectedErr.Error())
mockSAClient.EXPECT().ListKeys(gomock.Any(), b.common.resourceGroup, "foo").Return(storage.AccountListKeysResult{
Keys: &[]storage.AccountKey{