Merge pull request #110145 from sxllwx/fix/audit-union-var-closures

fix audit union loop variables in closures

staging/src/k8s.io/apiserver/pkg/audit/union.go

@@ -48,6 +48,7 @@ func (u union) ProcessEvents(events ...*auditinternal.Event) bool {
 func (u union) Run(stopCh <-chan struct{}) error {
 	var funcs []func() error
 	for _, backend := range u.backends {
+		backend := backend
 		funcs = append(funcs, func() error {
 			return backend.Run(stopCh)
 		})

staging/src/k8s.io/apiserver/pkg/audit/union_test.go

@@ -80,3 +80,36 @@ func TestUnion(t *testing.T) {
 		}
 	}
 }
+
+type cannotMultipleRunBackend struct {
+	started chan struct{}
+}
+
+func (b *cannotMultipleRunBackend) ProcessEvents(events ...*auditinternal.Event) bool {
+	return true
+}
+
+func (b *cannotMultipleRunBackend) Run(stopCh <-chan struct{}) error {
+	close(b.started)
+	return nil
+}
+
+func (b *cannotMultipleRunBackend) Shutdown() {}
+
+func (b *cannotMultipleRunBackend) String() string {
+	return "cannotMultipleRunBackend"
+}
+
+func TestUnionRun(t *testing.T) {
+	backends := []Backend{
+		&cannotMultipleRunBackend{started: make(chan struct{})},
+		&cannotMultipleRunBackend{started: make(chan struct{})},
+		&cannotMultipleRunBackend{started: make(chan struct{})},
+	}
+
+	b := Union(backends...)
+
+	if err := b.Run(make(chan struct{})); err != nil {
+		t.Errorf("union backend run: %v", err)
+	}
+}