github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-25 12:43:23 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #128038 from seans3/resource-quota-config-validation

Browse Source 
Enable strict validation for ResourceQuotaConfiguration
This commit is contained in:
Kubernetes Prow Robot 2024-10-15 02:04:27 +01:00 committed by GitHub
commit 510a7e7601
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/config.go
View File

@ -29,7 +29,7 @@ import (
var (
scheme = runtime.NewScheme()
codecs = serializer.NewCodecFactory(scheme)
codecs = serializer.NewCodecFactory(scheme, serializer.EnableStrict)
)
func init() {

28
staging/src/k8s.io/apiserver/pkg/admission/plugin/resourcequota/config_test.go
View File

@ -43,6 +43,34 @@ func TestLoadConfiguration(t *testing.T) {
input: `{"kind":"Unknown","apiVersion":"v1"}`,
expectErr: `no kind "Unknown" is registered`,
},
{
name: "duplicate field error; strict validation",
input: `
kind: ResourceQuotaConfiguration
apiVersion: apiserver.config.k8s.io/v1
limitedResources:
- apiGroup: ""
resource: persistentvolumeclaims
resource: persistentvolumeclaims
matchContains:
- .storageclass.storage.k8s.io/requests.storage
`,
expectErr: `strict decoding error`,
},
{
name: "unknown field error; strict validation",
input: `
kind: ResourceQuotaConfiguration
apiVersion: apiserver.config.k8s.io/v1
limitedResources:
- apiGroup: ""
foo: bar
resource: persistentvolumeclaims
matchContains:
- .storageclass.storage.k8s.io/requests.storage
`,
expectErr: `strict decoding error`,
},
{
name: "valid v1alpha1 config",
input: `