Clean up unnecessary else block and redundant variable assignment

This PR removes an unnecessary else block and eliminates a redundant variable assignment to improve code readability.
This commit is contained in:
myeunee 2024-09-09 00:34:03 +09:00
parent f5c5384181
commit 52e24a02ef

View File

@ -133,13 +133,12 @@ for more information about scheduling and the kube-scheduler component.`,
// runCommand runs the scheduler. // runCommand runs the scheduler.
func runCommand(cmd *cobra.Command, opts *options.Options, registryOptions ...Option) error { func runCommand(cmd *cobra.Command, opts *options.Options, registryOptions ...Option) error {
verflag.PrintAndExitIfRequested() verflag.PrintAndExitIfRequested()
fg := opts.ComponentGlobalsRegistry.FeatureGateFor(utilversion.DefaultKubeComponent)
// Activate logging as soon as possible, after that // Activate logging as soon as possible, after that
// show flags with the final logging configuration. // show flags with the final logging configuration.
if err := logsapi.ValidateAndApply(opts.Logs, fg); err != nil { if err := logsapi.ValidateAndApply(opts.Logs, opts.ComponentGlobalsRegistry.FeatureGateFor(utilversion.DefaultKubeComponent)); err != nil {
fmt.Fprintf(os.Stderr, "%v\n", err) fmt.Fprintf(os.Stderr, "%v\n", err)
os.Exit(1) os.Exit(1)
} }
cliflag.PrintFlags(cmd.Flags()) cliflag.PrintFlags(cmd.Flags())
ctx, cancel := context.WithCancel(context.Background()) ctx, cancel := context.WithCancel(context.Background())
@ -169,11 +168,12 @@ func Run(ctx context.Context, cc *schedulerserverconfig.CompletedConfig, sched *
logger.Info("Golang settings", "GOGC", os.Getenv("GOGC"), "GOMAXPROCS", os.Getenv("GOMAXPROCS"), "GOTRACEBACK", os.Getenv("GOTRACEBACK")) logger.Info("Golang settings", "GOGC", os.Getenv("GOGC"), "GOMAXPROCS", os.Getenv("GOMAXPROCS"), "GOTRACEBACK", os.Getenv("GOTRACEBACK"))
// Configz registration. // Configz registration.
if cz, err := configz.New("componentconfig"); err == nil { cz, err := configz.New("componentconfig")
cz.Set(cc.ComponentConfig) if err != nil {
} else {
return fmt.Errorf("unable to register configz: %s", err) return fmt.Errorf("unable to register configz: %s", err)
} }
cz.Set(cc.ComponentConfig)
// Start events processing pipeline. // Start events processing pipeline.
cc.EventBroadcaster.StartRecordingToSink(ctx.Done()) cc.EventBroadcaster.StartRecordingToSink(ctx.Done())