github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-11 04:52:08 +00:00
Code Issues Projects Releases Wiki Activity

ktesting: log warning on timeout

Browse Source 
How exactly a test reacts when its context times out is unclear. In the case of
scheduler_perf, the apiserver started to shut down and the test failure then
was about not being able to reach the apiserver, which was a bit confusing.

To make it more obvious why the shutdown starts, a WARNING message gets added
to the test output by ktesting before cancellation and thus before any other
output related to that cancellation.
This commit is contained in:
Patrick Ohly 2024-08-23 14:24:43 +02:00
parent cc9234cffd
commit 5447d28c0d
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/utils/ktesting/contexthelper.go
View File

@ -59,6 +59,14 @@ func withTimeout(ctx context.Context, tb TB, timeout time.Duration, timeoutCause
// No need to set a cause here. The cause or error of
// the parent context will be used.
case <-after.C:
// Code using this tCtx may or may not log the
// information above when it runs into the
// cancellation. It's better if we do it, just to be on
// the safe side.
//
// Would be nice to log this with the source code location
// of our caller, but testing.Logf does not support that.
tb.Logf("\nWARNING: %s\n", timeoutCause)
cancel(canceledError(timeoutCause))
}
}()