github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-24 20:24:09 +00:00
Code Issues Projects Releases Wiki Activity

Improve readability of scheduling failure logs

Browse Source
This commit is contained in:
Karl Isenberg 2015-08-13 12:06:01 -07:00 committed by Dr. Stefan Schimanski
parent b2e363fa08
commit 61c9dd876e
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
contrib/mesos/pkg/scheduler/plugin.go
View File

@ -754,10 +754,10 @@ func (s *schedulingPlugin) Run(done <-chan struct{}) {
// with the Modeler stuff removed since we don't use it because we have mesos. // with the Modeler stuff removed since we don't use it because we have mesos.
func (s *schedulingPlugin) scheduleOne() { func (s *schedulingPlugin) scheduleOne() {
pod := s.config.NextPod() pod := s.config.NextPod()
log.V(3).Infof("Attempting to schedule: %v", pod) log.V(3).Infof("Attempting to schedule: %+v", pod)
dest, err := s.config.Algorithm.Schedule(pod, s.config.MinionLister) // call kubeScheduler.Schedule dest, err := s.config.Algorithm.Schedule(pod, s.config.MinionLister) // call kubeScheduler.Schedule
if err != nil { if err != nil {
log.V(1).Infof("Failed to schedule: %v", pod) log.V(1).Infof("Failed to schedule: %+v", pod)
s.config.Recorder.Eventf(pod, "FailedScheduling", "Error scheduling: %v", err) s.config.Recorder.Eventf(pod, "FailedScheduling", "Error scheduling: %v", err)
s.config.Error(pod, err) s.config.Error(pod, err)
return return
@ -770,7 +770,7 @@ func (s *schedulingPlugin) scheduleOne() {
}, },
} }
if err := s.config.Binder.Bind(b); err != nil { if err := s.config.Binder.Bind(b); err != nil {
log.V(1).Infof("Failed to bind pod: %v", err) log.V(1).Infof("Failed to bind pod: %+v", err)
s.config.Recorder.Eventf(pod, "FailedScheduling", "Binding rejected: %v", err) s.config.Recorder.Eventf(pod, "FailedScheduling", "Binding rejected: %v", err)
s.config.Error(pod, err) s.config.Error(pod, err)
return return

6
plugin/pkg/scheduler/scheduler.go
View File

@ -116,7 +116,7 @@ func (s *Scheduler) scheduleOne() {
s.config.BindPodsRateLimiter.Accept() s.config.BindPodsRateLimiter.Accept()
} }
glog.V(3).Infof("Attempting to schedule: %v", pod) glog.V(3).Infof("Attempting to schedule: %+v", pod)
start := time.Now() start := time.Now()
defer func() { defer func() {
metrics.E2eSchedulingLatency.Observe(metrics.SinceInMicroseconds(start)) metrics.E2eSchedulingLatency.Observe(metrics.SinceInMicroseconds(start))
@ -124,7 +124,7 @@ func (s *Scheduler) scheduleOne() {
dest, err := s.config.Algorithm.Schedule(pod, s.config.MinionLister) dest, err := s.config.Algorithm.Schedule(pod, s.config.MinionLister)
metrics.SchedulingAlgorithmLatency.Observe(metrics.SinceInMicroseconds(start)) metrics.SchedulingAlgorithmLatency.Observe(metrics.SinceInMicroseconds(start))
if err != nil { if err != nil {
glog.V(1).Infof("Failed to schedule: %v", pod) glog.V(1).Infof("Failed to schedule: %+v", pod)
s.config.Recorder.Eventf(pod, "FailedScheduling", "%v", err) s.config.Recorder.Eventf(pod, "FailedScheduling", "%v", err)
s.config.Error(pod, err) s.config.Error(pod, err)
return return
@ -144,7 +144,7 @@ func (s *Scheduler) scheduleOne() {
err := s.config.Binder.Bind(b) err := s.config.Binder.Bind(b)
metrics.BindingLatency.Observe(metrics.SinceInMicroseconds(bindingStart)) metrics.BindingLatency.Observe(metrics.SinceInMicroseconds(bindingStart))
if err != nil { if err != nil {
glog.V(1).Infof("Failed to bind pod: %v", err) glog.V(1).Infof("Failed to bind pod: %+v", err)
s.config.Recorder.Eventf(pod, "FailedScheduling", "Binding rejected: %v", err) s.config.Recorder.Eventf(pod, "FailedScheduling", "Binding rejected: %v", err)
s.config.Error(pod, err) s.config.Error(pod, err)
return return