github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-21 19:01:49 +00:00
Code Issues Projects Releases Wiki Activity

node: e2e: address review comments (2022/12/12)

Browse Source 
- use `ginkgo.DeferCleanup` instead of clean up in the AfterEach block
- encourage use of ginkgo by not extending expect.go

Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
This commit is contained in:
Swati Sehgal 2022-12-12 16:31:40 +00:00
parent a9e3689e63
commit 62e4d39c2f
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/e2e_node/container_log_rotation_test.go
View File

@ -74,12 +74,7 @@ var _ = SIGDescribe("ContainerLogRotation [Slow] [Serial] [Disruptive]", func()
},
}
logRotationPod = e2epod.NewPodClient(f).CreateSync(pod)
})
ginkgo.AfterEach(func() {
ginkgo.By("Deleting the log-rotation pod")
framework.Logf("Deleting pod: %s", logRotationPod.Name)
e2epod.NewPodClient(f).DeleteSync(logRotationPod.Name, metav1.DeleteOptions{}, time.Minute)
ginkgo.DeferCleanup(e2epod.NewPodClient(f).DeleteSync, logRotationPod.Name, metav1.DeleteOptions{}, time.Minute)
})
ginkgo.It("should be rotated and limited to a fixed amount of files", func(ctx context.Context) {