github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-24 04:06:03 +00:00
Code Issues Projects Releases Wiki Activity

Prevent dirty service object leaking between reconciles

Browse Source
This commit is contained in:
Matthew Booth 2022-04-21 20:57:48 +01:00
parent f173d01c01
commit 68ad099b7b
No known key found for this signature in database
GPG Key ID: D3685B1BA4459B87
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
staging/src/k8s.io/cloud-provider/controllers/service/controller.go
View File

@ -876,7 +876,10 @@ func (s *Controller) syncService(ctx context.Context, key string) error {
case err != nil:
runtime.HandleError(fmt.Errorf("Unable to retrieve service %v from store: %v", key, err))
default:
err = s.processServiceCreateOrUpdate(ctx, service, key)
// It is not safe to modify an object returned from an informer.
// As reconcilers may modify the service object we need to copy
// it first.
err = s.processServiceCreateOrUpdate(ctx, service.DeepCopy(), key)
}
return err