github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 14:37:00 +00:00
Code Issues Projects Releases Wiki Activity

dns: don't die when a headless service declares no ports

Browse Source 
Headless services are not required to declare ports.

Signed-off-by: Mike Danese <mikedanese@google.com>
This commit is contained in:
Mike Danese 2016-01-13 10:36:08 -08:00
parent 10f7985dfb
commit 69add2fb80
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cluster/addons/dns/kube2sky/kube2sky.go
View File

@ -338,13 +338,13 @@ func (ks *kube2sky) generateSRVRecord(subdomain, portSegment, recordName, cName
} }
func (ks *kube2sky) addDNS(subdomain string, service *kapi.Service) error { func (ks *kube2sky) addDNS(subdomain string, service *kapi.Service) error {
if len(service.Spec.Ports) == 0 {
glog.Fatalf("Unexpected service with no ports: %v", service)
}
// if ClusterIP is not set, a DNS entry should not be created // if ClusterIP is not set, a DNS entry should not be created
if !kapi.IsServiceIPSet(service) { if !kapi.IsServiceIPSet(service) {
return ks.newHeadlessService(subdomain, service) return ks.newHeadlessService(subdomain, service)
} }
if len(service.Spec.Ports) == 0 {
glog.Info("Unexpected service with no ports, this should not have happend: %v", service)
}
return ks.generateRecordsForPortalService(subdomain, service) return ks.generateRecordsForPortalService(subdomain, service)
} }