github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 15:25:57 +00:00
Code Issues Projects Releases Wiki Activity

Clean up testing code of kubectl cmd section

Browse Source
This commit is contained in:
weikhor 2022-10-27 22:18:42 -04:00
parent f9f9f0107d
commit 69b0b731e9
3 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
staging/src/k8s.io/kubectl/pkg/cmd/annotate/annotate_test.go
View File

@ -383,7 +383,6 @@ func TestUpdateAnnotations(t *testing.T) {
func TestAnnotateErrors(t *testing.T) {
testCases := map[string]struct {
args []string
flags map[string]string
errFn func(error) bool
}{
"no args": {
@ -430,9 +429,6 @@ func TestAnnotateErrors(t *testing.T) {
cmd.SetOut(bufOut)
cmd.SetErr(bufOut)
for k, v := range testCase.flags {
cmd.Flags().Set(k, v)
}
options := NewAnnotateOptions(iostreams)
err := options.Complete(tf, cmd, testCase.args)
if err == nil {
@ -443,10 +439,10 @@ func TestAnnotateErrors(t *testing.T) {
return
}
if bufOut.Len() > 0 {
t.Errorf("buffer should be empty: %s", string(bufOut.Bytes()))
t.Errorf("buffer should be empty: %s", bufOut.String())
}
if bufErr.Len() > 0 {
t.Errorf("buffer should be empty: %s", string(bufErr.Bytes()))
t.Errorf("buffer should be empty: %s", bufErr.String())
}
})
}

1
staging/src/k8s.io/kubectl/pkg/cmd/clusterinfo/clusterinfo_dump_test.go
View File

@ -41,7 +41,6 @@ func TestSetupOutputWriterNoOp(t *testing.T) {
},
}
for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
_, _, buf, _ := genericclioptions.NewTestIOStreams()
f := cmdtesting.NewTestFactory()

4
staging/src/k8s.io/kubectl/pkg/cmd/label/label_test.go
View File

@ -301,7 +301,6 @@ func TestLabelFunc(t *testing.T) {
func TestLabelErrors(t *testing.T) {
testCases := map[string]struct {
args []string
flags map[string]string
errFn func(error) bool
}{
"no args": {
@ -355,9 +354,6 @@ func TestLabelErrors(t *testing.T) {
cmd.SetOut(buf)
cmd.SetErr(buf)
for k, v := range testCase.flags {
cmd.Flags().Set(k, v)
}
opts := NewLabelOptions(ioStreams)
err := opts.Complete(tf, cmd, testCase.args)
if err == nil {