github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-30 15:05:27 +00:00
Code Issues Projects Releases Wiki Activity

registry: remove todos about rc/rs label/annotation updates

Browse Source
This commit is contained in:
kargakis 2016-02-22 17:28:38 +01:00
parent 6716344d24
commit 69cd75c6a8
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/registry/controller/strategy.go
View File

@ -69,9 +69,6 @@ func (rcStrategy) PrepareForUpdate(obj, old runtime.Object) {
// status its own object, and even if we don't, writes may be the result of a // status its own object, and even if we don't, writes may be the result of a
// read-update-write loop, so the contents of spec may not actually be the spec that // read-update-write loop, so the contents of spec may not actually be the spec that
// the controller has *seen*. // the controller has *seen*.
//
// TODO: Any changes to a part of the object that represents desired state (labels,
// annotations etc) should also increment the generation.
if !reflect.DeepEqual(oldController.Spec, newController.Spec) { if !reflect.DeepEqual(oldController.Spec, newController.Spec) {
newController.Generation = oldController.Generation + 1 newController.Generation = oldController.Generation + 1
} }

3
pkg/registry/replicaset/strategy.go
View File

@ -70,9 +70,6 @@ func (rsStrategy) PrepareForUpdate(obj, old runtime.Object) {
// status its own object, and even if we don't, writes may be the result of a // status its own object, and even if we don't, writes may be the result of a
// read-update-write loop, so the contents of spec may not actually be the spec that // read-update-write loop, so the contents of spec may not actually be the spec that
// the ReplicaSet has *seen*. // the ReplicaSet has *seen*.
//
// TODO: Any changes to a part of the object that represents desired state (labels,
// annotations etc) should also increment the generation.
if !reflect.DeepEqual(oldRS.Spec, newRS.Spec) { if !reflect.DeepEqual(oldRS.Spec, newRS.Spec) {
newRS.Generation = oldRS.Generation + 1 newRS.Generation = oldRS.Generation + 1
} }