Merge pull request #4802 from brendandburns/log

Add specific errors for missing kind and version.

pkg/conversion/error.go

@@ -49,3 +49,35 @@ func IsNotRegisteredError(err error) bool {
 	_, ok := err.(*notRegisteredErr)
 	return ok
 }
+
+type missingKindErr struct {
+	data string
+}
+
+func (k *missingKindErr) Error() string {
+	return fmt.Sprintf("Object 'Kind' is missing in '%s'", k.data)
+}
+
+func IsMissingKind(err error) bool {
+	if err == nil {
+		return false
+	}
+	_, ok := err.(*missingKindErr)
+	return ok
+}
+
+type missingVersionErr struct {
+	data string
+}
+
+func (k *missingVersionErr) Error() string {
+	return fmt.Sprintf("Object 'apiVersion' is missing in '%s'", k.data)
+}
+
+func IsMissingVersion(err error) bool {
+	if err == nil {
+		return false
+	}
+	_, ok := err.(*missingVersionErr)
+	return ok
+}

pkg/runtime/error.go

@@ -25,3 +25,15 @@ import (
 func IsNotRegisteredError(err error) bool {
 	return conversion.IsNotRegisteredError(err)
 }
+
+// IsMissingKind returns true if the error indicates that the provided object
+// is missing a 'Kind' field.
+func IsMissingKind(err error) bool {
+	return conversion.IsMissingKind(err)
+}
+
+// IsMissingVersion returns true if the error indicates that the provided object
+// is missing a 'Versioj' field.
+func IsMissingVersion(err error) bool {
+	return conversion.IsMissingVersion(err)
+}