github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-15 14:14:39 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #123152 from tnqn/fix-error-log

Browse Source 
Fix internal error when serializing groupLookupFailures in log
This commit is contained in:
Kubernetes Prow Robot
2024-10-23 01:17:29 +01:00
committed by GitHub
parent e6659b60f8 3160386f29
commit 6edbee19b9
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/controller/garbagecollector/garbagecollector.go
View File

@@ -782,7 +782,9 @@ func GetDeletableResources(logger klog.Logger, discoveryClient discovery.ServerR
preferredResources, lookupErr := discoveryClient.ServerPreferredResources()
if lookupErr != nil {
if groupLookupFailures, isLookupFailure := discovery.GroupDiscoveryFailedErrorGroups(lookupErr); isLookupFailure {
logger.Info("failed to discover some groups", "groups", groupLookupFailures)
// Serialize groupLookupFailures here as map[schema.GroupVersion]error is not json encodable, otherwise the
// logger would throw internal error.
logger.Info("failed to discover some groups", "groups", fmt.Sprintf("%q", groupLookupFailures))
} else {
logger.Info("failed to discover preferred resources", "error", lookupErr)
}