github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-17 15:50:10 +00:00
Code Issues Projects Releases Wiki Activity

cleanup: Use map[string]struct{} instead of map[string]bool for memory optimization

Browse Source 
Signed-off-by: xovoxy <xilovele@gmail.com>
This commit is contained in:
xovoxy 2024-08-14 11:15:31 +08:00
parent 9d140b136c
commit 74ce6e9f1b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
staging/src/k8s.io/component-base/cli/flag/flags.go
View File

@ -24,7 +24,7 @@ import (
"k8s.io/klog/v2" "k8s.io/klog/v2"
) )
var underscoreWarnings = make(map[string]bool) var underscoreWarnings = make(map[string]struct{})
// WordSepNormalizeFunc changes all flags that contain "_" separators // WordSepNormalizeFunc changes all flags that contain "_" separators
func WordSepNormalizeFunc(f *pflag.FlagSet, name string) pflag.NormalizedName { func WordSepNormalizeFunc(f *pflag.FlagSet, name string) pflag.NormalizedName {
@ -40,7 +40,7 @@ func WarnWordSepNormalizeFunc(f *pflag.FlagSet, name string) pflag.NormalizedNam
nname := strings.Replace(name, "_", "-", -1) nname := strings.Replace(name, "_", "-", -1)
if _, alreadyWarned := underscoreWarnings[name]; !alreadyWarned { if _, alreadyWarned := underscoreWarnings[name]; !alreadyWarned {
klog.Warningf("using an underscore in a flag name is not supported. %s has been converted to %s.", name, nname) klog.Warningf("using an underscore in a flag name is not supported. %s has been converted to %s.", name, nname)
underscoreWarnings[name] = true underscoreWarnings[name] = struct{}{}
} }
return pflag.NormalizedName(nname) return pflag.NormalizedName(nname)