cleanup: Use map[string]struct{} instead of map[string]bool for memory optimization

Signed-off-by: xovoxy <xilovele@gmail.com>
This commit is contained in:
xovoxy 2024-08-14 11:15:31 +08:00
parent 9d140b136c
commit 74ce6e9f1b

View File

@ -24,7 +24,7 @@ import (
"k8s.io/klog/v2"
)
var underscoreWarnings = make(map[string]bool)
var underscoreWarnings = make(map[string]struct{})
// WordSepNormalizeFunc changes all flags that contain "_" separators
func WordSepNormalizeFunc(f *pflag.FlagSet, name string) pflag.NormalizedName {
@ -40,7 +40,7 @@ func WarnWordSepNormalizeFunc(f *pflag.FlagSet, name string) pflag.NormalizedNam
nname := strings.Replace(name, "_", "-", -1)
if _, alreadyWarned := underscoreWarnings[name]; !alreadyWarned {
klog.Warningf("using an underscore in a flag name is not supported. %s has been converted to %s.", name, nname)
underscoreWarnings[name] = true
underscoreWarnings[name] = struct{}{}
}
return pflag.NormalizedName(nname)