enable verify-golangci-lint.sh

Signed-off-by: Davanum Srinivas <davanum@gmail.com>

hack/make-rules/verify.sh

@@ -35,7 +35,6 @@ EXCLUDED_PATTERNS=(
   "verify-linkcheck.sh"          # runs in separate Jenkins job once per day due to high network usage
   "verify-*-dockerized.sh"       # Don't run any scripts that intended to be run dockerized
   "verify-govet-levee.sh"        # Do not run levee analysis by default while KEP-1933 implementation is in alpha.
-  "verify-golangci-lint.sh"      # Experimental - intended to be run by hand periodically
   )
 
 # Exclude generated-files-remake in certain cases, if they're running in a separate job.

pkg/apis/storage/validation/validation_test.go

@@ -1696,8 +1696,7 @@ func TestCSIDriverValidation(t *testing.T) {
 	storageCapacity := true
 	notStorageCapacity := false
 	supportedFSGroupPolicy := storage.FileFSGroupPolicy
-	invalidFSGroupPolicy := storage.ReadWriteOnceWithFSTypeFSGroupPolicy //nolint:ineffassign
-	invalidFSGroupPolicy = "invalid-mode"
+	invalidFSGroupPolicy := storage.FSGroupPolicy("invalid-mode")
 	successCases := []storage.CSIDriver{
 		{
 			ObjectMeta: metav1.ObjectMeta{Name: driverName},
@@ -2051,8 +2050,7 @@ func TestCSIDriverValidationUpdate(t *testing.T) {
 		{
 			name: "FSGroupPolicy invalidated",
 			modify: func(new *storage.CSIDriver) {
-				invalidFSGroupPolicy := storage.ReadWriteOnceWithFSTypeFSGroupPolicy //nolint:ineffassign
-				invalidFSGroupPolicy = "invalid"
+				invalidFSGroupPolicy := storage.FSGroupPolicy("invalid")
 				new.Spec.FSGroupPolicy = &invalidFSGroupPolicy
 			},
 		},

pkg/generated/openapi/cmd/models-schema/main.go

@@ -59,7 +59,7 @@ func output() error {
 	if err != nil {
 		return fmt.Errorf("error serializing api definitions: %w", err)
 	}
-	_, _ = os.Stdout.Write(data)
+	os.Stdout.Write(data)
 	return nil
 }
 

pkg/kubelet/certificate/bootstrap/bootstrap_test.go

@@ -387,7 +387,8 @@ func TestRequestNodeCertificate(t *testing.T) {
 type failureType int
 
 const (
-	createError = iota
+	noError failureType = iota //nolint:deadcode,varcheck
+	createError
 	certificateSigningRequestDenied
 )
 

test/e2e/common/node/pods.go

@@ -244,6 +244,7 @@ var _ = SIGDescribe("Pods", func() {
 		pods, err := podClient.List(context.TODO(), options)
 		framework.ExpectNoError(err, "failed to query for pods")
 		framework.ExpectEqual(len(pods.Items), 0)
+
 		listCompleted := make(chan bool, 1)
 		lw := &cache.ListWatch{
 			ListFunc: func(options metav1.ListOptions) (runtime.Object, error) {

test/e2e/network/ingress.go

@@ -47,7 +47,7 @@ import (
 )
 
 const (
-	negUpdateTimeout        = 2 * time.Minute
+	negUpdateTimeout = 2 * time.Minute
 )
 
 var _ = common.SIGDescribe("Loadbalancing: L7", func() {

test/e2e/scheduling/limit_range.go

@@ -72,6 +72,7 @@ var _ = SIGDescribe("LimitRange", func() {
 		limitRanges, err := f.ClientSet.CoreV1().LimitRanges(f.Namespace.Name).List(context.TODO(), options)
 		framework.ExpectNoError(err, "failed to query for limitRanges")
 		framework.ExpectEqual(len(limitRanges.Items), 0)
+
 		listCompleted := make(chan bool, 1)
 		lw := &cache.ListWatch{
 			ListFunc: func(options metav1.ListOptions) (runtime.Object, error) {