github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-10 20:42:26 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #129418 from neolit123/1.33-fix-upgrade-addon-skip

Browse Source 
kubeadm: skip disabled addons in clusterconfig on upgrade
This commit is contained in:
Kubernetes Prow Robot 2024-12-30 09:10:13 +01:00 committed by GitHub
commit 7606b77fff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
cmd/kubeadm/app/cmd/phases/upgrade/addons.go
View File

@ -83,13 +83,20 @@ func getInitData(c workflow.RunData) (*kubeadmapi.InitConfiguration, clientset.I
// runCoreDNSAddon upgrades the CoreDNS addon.
func runCoreDNSAddon(c workflow.RunData) error {
const skipMessagePrefix = "[upgrade/addon] Skipping the addon/coredns phase."
cfg, client, patchesDir, out, dryRun, isControlPlaneNode, err := getInitData(c)
if err != nil {
return err
}
if !isControlPlaneNode {
fmt.Println("[upgrade/addon] Skipping addon/coredns phase. Not a control plane node.")
fmt.Fprintf(out, "%s Not a control plane node.\n", skipMessagePrefix)
return nil
}
if cfg.ClusterConfiguration.DNS.Disabled {
fmt.Fprintf(out, "%s The addon is disabled.\n", skipMessagePrefix)
return nil
}
@ -110,13 +117,20 @@ func runCoreDNSAddon(c workflow.RunData) error {
// runKubeProxyAddon upgrades the kube-proxy addon.
func runKubeProxyAddon(c workflow.RunData) error {
const skipMessagePrefix = "[upgrade/addon] Skipping the addon/kube-proxy phase."
cfg, client, _, out, dryRun, isControlPlaneNode, err := getInitData(c)
if err != nil {
return err
}
if !isControlPlaneNode {
fmt.Println("[upgrade/addon] Skipping addon/kube-proxy phase. Not a control plane node.")
fmt.Fprintf(out, "%s Not a control plane node.\n", skipMessagePrefix)
return nil
}
if cfg.ClusterConfiguration.Proxy.Disabled {
fmt.Fprintf(out, "%s The addon is disabled.\n", skipMessagePrefix)
return nil
}