github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-07-19 07:25:19 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #134816 from swatisehgal/device-plugin-e2e-flakiness-2

Browse Source 
node: e2e: update podresources check post fix of kubernetes#119423
This commit is contained in:
Kubernetes Prow Robot
2025-10-28 07:49:42 -07:00
committed by GitHub
parent d5efbf2ebf 1e3a6e18d0
commit 7be689fcd6
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
test/e2e_node/device_plugin_test.go
View File

@@ -989,17 +989,14 @@ func testDevicePluginNodeReboot(f *framework.Framework, pluginSockDir string) {
return err
}, 30*time.Second, framework.Poll).ShouldNot(gomega.HaveOccurred(), "cannot fetch the compute resource assignment after kubelet restart")
// if we got this far, podresources API will now report 2 entries:
// - sample device plugin pod, running and doing fine
// - our test pod, in failed state. Pods in terminal state will still be reported, see https://github.com/kubernetes/kubernetes/issues/119423
// so we care about our test pod, and it will be present in the returned list till 119423 is fixed, but since it failed admission it must not have
// any device allocated to it, hence we check for empty device set in the podresources response. So, we check that
// A. our test pod must be present in the list response *and*
// B. it has no devices assigned to it.
// anything else is unexpected and thus makes the test fail. Once 119423 is fixed, a better, simpler and more intuitive check will be for the
// test pod to not be present in the podresources list response, but till that time we're stuck with this approach.
// if we got this far, podresources API will now report only the sample device plugin pod,
// because pods that failed admission are no longer reported in the list
// (see https://github.com/kubernetes/kubernetes/pull/132028).
// Hence, we verify that our test pod is NOT present in the podresources response.
_, found := checkPodResourcesAssignment(v1PodResources, pod1.Namespace, pod1.Name, pod1.Spec.Containers[0].Name, SampleDeviceResourceName, []string{})
gomega.Expect(found).To(gomega.BeTrueBecause("%s/%s/%s failed admission, should not have devices registered", pod1.Namespace, pod1.Name, pod1.Spec.Containers[0].Name))
framework.ExpectNoError(err, "unexpected device assignment mismatch for %s/%s", pod1.Namespace, pod1.Name)
gomega.Expect(found).To(gomega.BeFalseBecause("%s/%s/%s failed admission, so it must not appear in podresources list", pod1.Namespace, pod1.Name, pod1.Spec.Containers[0].Name))
})
})
}