mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-08-01 15:58:37 +00:00
Ignore false positives from unused linter
This is a workaround for a false positive in the staticcheck linter, which has not been addressed yet. See https://github.com/dominikh/go-tools/issues/1294. Once this is fixed in staticcheck, we can just remove the exclude rule from the golangci config. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
This commit is contained in:
parent
1aec7568e1
commit
7dc4af6c8a
@ -77,6 +77,17 @@ issues:
|
||||
text: comment on exported (method|function|type|const)|should have( a package)? comment|comment should be of the form|comment on exported (method|function|type|const)|should have( a package)? comment|comment should be of the form|exported (.+) should have comment( \(or a comment on this block\))? or be unexported|package comment should be of the form "(.+)...|comment on exported (.+) should be of the form "(.+)...|should have a package comment
|
||||
path-except: cmd/kubeadm
|
||||
|
||||
# The unused linter that comes from staticcheck currently does not handle types which implement
|
||||
# a generic interface. The linter incorrectly reports the implementations of unexported
|
||||
# interface methods as unused. See https://github.com/dominikh/go-tools/issues/1294.
|
||||
# Rather than exporting the interface methods, which makes the error go away but changes the
|
||||
# semantics of the code, we ignore this error for affected files.
|
||||
# This can be removed when the staticcheck implementation of this rule is fixed, which may
|
||||
# depend on https://github.com/golang/go/issues/63982.
|
||||
- linters:
|
||||
- unused
|
||||
path: staging/src/k8s.io/client-go/util/workqueue/metrics.go
|
||||
|
||||
linters:
|
||||
disable-all: false
|
||||
enable: # please keep this alphabetized
|
||||
|
@ -77,6 +77,17 @@ issues:
|
||||
text: comment on exported (method|function|type|const)|should have( a package)? comment|comment should be of the form|comment on exported (method|function|type|const)|should have( a package)? comment|comment should be of the form|exported (.+) should have comment( \(or a comment on this block\))? or be unexported|package comment should be of the form "(.+)...|comment on exported (.+) should be of the form "(.+)...|should have a package comment
|
||||
path-except: cmd/kubeadm
|
||||
|
||||
# The unused linter that comes from staticcheck currently does not handle types which implement
|
||||
# a generic interface. The linter incorrectly reports the implementations of unexported
|
||||
# interface methods as unused. See https://github.com/dominikh/go-tools/issues/1294.
|
||||
# Rather than exporting the interface methods, which makes the error go away but changes the
|
||||
# semantics of the code, we ignore this error for affected files.
|
||||
# This can be removed when the staticcheck implementation of this rule is fixed, which may
|
||||
# depend on https://github.com/golang/go/issues/63982.
|
||||
- linters:
|
||||
- unused
|
||||
path: staging/src/k8s.io/client-go/util/workqueue/metrics.go
|
||||
|
||||
# The following issues were deemed "might be worth fixing, needs to be
|
||||
# decided on a case-by-case basis". This was initially decided by a
|
||||
# majority of the developers who voted in
|
||||
|
@ -83,6 +83,17 @@ issues:
|
||||
text: comment on exported (method|function|type|const)|should have( a package)? comment|comment should be of the form|comment on exported (method|function|type|const)|should have( a package)? comment|comment should be of the form|exported (.+) should have comment( \(or a comment on this block\))? or be unexported|package comment should be of the form "(.+)...|comment on exported (.+) should be of the form "(.+)...|should have a package comment
|
||||
path-except: cmd/kubeadm
|
||||
|
||||
# The unused linter that comes from staticcheck currently does not handle types which implement
|
||||
# a generic interface. The linter incorrectly reports the implementations of unexported
|
||||
# interface methods as unused. See https://github.com/dominikh/go-tools/issues/1294.
|
||||
# Rather than exporting the interface methods, which makes the error go away but changes the
|
||||
# semantics of the code, we ignore this error for affected files.
|
||||
# This can be removed when the staticcheck implementation of this rule is fixed, which may
|
||||
# depend on https://github.com/golang/go/issues/63982.
|
||||
- linters:
|
||||
- unused
|
||||
path: staging/src/k8s.io/client-go/util/workqueue/metrics.go
|
||||
|
||||
# The following issues were deemed "might be worth fixing, needs to be
|
||||
# decided on a case-by-case basis". This was initially decided by a
|
||||
# majority of the developers who voted in
|
||||
|
@ -86,6 +86,17 @@ issues:
|
||||
text: comment on exported (method|function|type|const)|should have( a package)? comment|comment should be of the form|comment on exported (method|function|type|const)|should have( a package)? comment|comment should be of the form|exported (.+) should have comment( \(or a comment on this block\))? or be unexported|package comment should be of the form "(.+)...|comment on exported (.+) should be of the form "(.+)...|should have a package comment
|
||||
path-except: cmd/kubeadm
|
||||
|
||||
# The unused linter that comes from staticcheck currently does not handle types which implement
|
||||
# a generic interface. The linter incorrectly reports the implementations of unexported
|
||||
# interface methods as unused. See https://github.com/dominikh/go-tools/issues/1294.
|
||||
# Rather than exporting the interface methods, which makes the error go away but changes the
|
||||
# semantics of the code, we ignore this error for affected files.
|
||||
# This can be removed when the staticcheck implementation of this rule is fixed, which may
|
||||
# depend on https://github.com/golang/go/issues/63982.
|
||||
- linters:
|
||||
- unused
|
||||
path: staging/src/k8s.io/client-go/util/workqueue/metrics.go
|
||||
|
||||
{{- if not .Hints}}
|
||||
|
||||
# The following issues were deemed "might be worth fixing, needs to be
|
||||
|
Loading…
Reference in New Issue
Block a user