Address review comments

This commit is contained in:
Tariq Ibrahim 2019-08-13 09:07:39 -07:00 committed by GitHub
parent 06e1b38768
commit 8056403823
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -168,17 +168,17 @@ func TestEventSeriesf(t *testing.T) {
if item.expectUpdate {
actualEvent := <-patchEvent
t.Logf("%v - validating event affected by patch request", index)
validateEventSeries(strconv.Itoa(index), true, actualEvent, item.expect, t)
validateEvent(strconv.Itoa(index), true, actualEvent, item.expect, t)
} else {
actualEvent := <-createEvent
t.Logf("%v - validating event affected by a create request", index)
validateEventSeries(strconv.Itoa(index), false, actualEvent, item.expect, t)
validateEvent(strconv.Itoa(index), false, actualEvent, item.expect, t)
}
}
close(stopCh)
}
func validateEventSeries(messagePrefix string, expectedUpdate bool, actualEvent *v1beta1.Event, expectedEvent *v1beta1.Event, t *testing.T) {
func validateEvent(messagePrefix string, expectedUpdate bool, actualEvent *v1beta1.Event, expectedEvent *v1beta1.Event, t *testing.T) {
recvEvent := *actualEvent
// Just check that the timestamp was set.