github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-30 06:54:01 +00:00
Code Issues Projects Releases Wiki Activity

kubeadm: preflight should only warn about unresolvable hostnames

Browse Source 
This is quite often the case on AWS, and we really don't care if
the hostname is resolvable or not. It's not an easy problem
to ask user to fix, and there is no functional penalty at the
Kubernetes level, also it's possible that users fixes their host
resolution eventually, we don't have to make them do so.
This commit is contained in:
Ilya Dmitrichenko 2017-02-09 23:11:26 +00:00
parent e1720af730
commit 829c47f94d
No known key found for this signature in database
GPG Key ID: E7889175A6C0CEB9
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
cmd/kubeadm/app/preflight/checks.go
View File

@ -239,18 +239,19 @@ type HostnameCheck struct{}
func (hc HostnameCheck) Check() (warnings, errors []error) {
errors = []error{}
warnings = []error{}
hostname := node.GetHostname("")
for _, msg := range validation.ValidateNodeName(hostname, false) {
errors = append(errors, fmt.Errorf("hostname \"%s\" %s", hostname, msg))
}
addr, err := net.LookupHost(hostname)
if addr == nil {
errors = append(errors, fmt.Errorf("hostname \"%s\" could not be reached", hostname))
warnings = append(warnings, fmt.Errorf("hostname \"%s\" could not be reached", hostname))
}
if err != nil {
errors = append(errors, fmt.Errorf("hostname \"%s\" %s", hostname, err))
warnings = append(warnings, fmt.Errorf("hostname \"%s\" %s", hostname, err))
}
return nil, errors
return warnings, errors
}
// HTTPProxyCheck checks if https connection to specific host is going