github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-07-19 07:25:19 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #133419 from Xdynix/fix-label-selector-consecutive-commas

Browse Source 
Fix label selector parsing for consecutive commas
This commit is contained in:
Kubernetes Prow Robot
2025-08-27 17:18:41 -07:00
committed by GitHub
parent 5742171781 d4f8bebda0
commit 82f66bbca7
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
staging/src/k8s.io/apimachinery/pkg/labels/selector.go
View File

@@ -848,7 +848,6 @@ func (p *Parser) parseIdentifiersList() (sets.String, error) {
return s, nil
}
if tok2 == CommaToken {
p.consume(Values)
s.Insert("") // to handle ,, Double "" removed by StringSet
}
default: // it can be operator

15
staging/src/k8s.io/apimachinery/pkg/labels/selector_test.go
View File

@@ -636,9 +636,24 @@ func TestSetSelectorParser(t *testing.T) {
{"x in (abc,)", internalSelector{
getRequirement("x", selection.In, sets.NewString("abc", ""), t),
}, true, true},
{"x in (abc,abc)", internalSelector{
getRequirement("x", selection.In, sets.NewString("abc"), t),
}, true, true},
{"x in ()", internalSelector{
getRequirement("x", selection.In, sets.NewString(""), t),
}, true, true},
{"x in (a,,)", internalSelector{
getRequirement("x", selection.In, sets.NewString("a", ""), t),
}, true, true},
{"x in (a,,,)", internalSelector{
getRequirement("x", selection.In, sets.NewString("a", ""), t),
}, true, true},
{"x in (a,,,,,,)", internalSelector{
getRequirement("x", selection.In, sets.NewString("a", ""), t),
}, true, true},
{"x in (a,,a,,a,,a,,)", internalSelector{
getRequirement("x", selection.In, sets.NewString("a", ""), t),
}, true, true},
{"x notin (abc,,def),bar,z in (),w", internalSelector{
getRequirement("bar", selection.Exists, nil, t),
getRequirement("w", selection.Exists, nil, t),