Merge pull request #55503 from mml/conformance

Automatic merge from submit-queue (batch tested with PRs 52461, 55503). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

A few improvements to the conformance regtesst

- Set OWNERS files to disallow parent approvers (doesn't work yet, but should be live next week.)
- Document how to fix failing test.
- Add a better error message.

```release-note
NONE
```
This commit is contained in:
Kubernetes Submit Queue 2017-11-11 15:21:32 -08:00 committed by GitHub
commit 858f3cbf59
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 2 deletions

View File

@ -0,0 +1,15 @@
This directory contains the regression test for controlling the list of all
conformance tests.
If you add or remove a conformance test, this test will fail and you will need
to update the golden list of tests stored in `testdata/`. Changes to that file
require review by sig-architecture.
To update the list, run
```console
$ bazel build //test/conformance:list_conformance_tests
$ cp bazel-genfiles/test/conformance/conformance.txt test/conformance/testdata
```
Add the changed file to your PR, then send for review.

View File

@ -21,5 +21,9 @@
set -o errexit
diff -u test/conformance/testdata/conformance.txt test/conformance/conformance.txt
echo PASS
if diff -u test/conformance/testdata/conformance.txt test/conformance/conformance.txt; then
echo PASS
exit 0
fi
echo 'See instructions in test/conformance/README.md'
exit 1

View File

@ -1,6 +1,8 @@
# To be owned by sig-architecture.
# TODO(mml): Exclude parent owners once
# https://github.com/kubernetes/test-infra/issues/5197 is implemented.
options:
- no_parent_owners: true
reviewers:
- bgrant0607
- smarterclayton