Revert "Generate Stack Traces for http response with status code zero"

Does not help with the bug investigation. the http server is designed to
panic when the http status code is `0`.

This reverts commit 72792d59f4.
This commit is contained in:
Davanum Srinivas
2019-01-04 15:26:07 -05:00
parent 62e8a1bf40
commit 85ae15621a

View File

@@ -25,17 +25,6 @@ import (
"k8s.io/apiserver/pkg/server/httplog"
)
func badHTTPResponse() httplog.StacktracePred {
return func(status int) bool {
// http status code should not be zero
if status == 0 {
klog.Errorf("Bad HTTP Response - status is zero")
return true
}
return false
}
}
// WithPanicRecovery wraps an http Handler to recover and log panics.
func WithPanicRecovery(handler http.Handler) http.Handler {
return withPanicRecovery(handler, func(w http.ResponseWriter, req *http.Request, err interface{}) {
@@ -50,7 +39,7 @@ func withPanicRecovery(handler http.Handler, crashHandler func(http.ResponseWrit
crashHandler(w, req, err)
})
logger := httplog.NewLogged(req, &w).StacktraceWhen(badHTTPResponse())
logger := httplog.NewLogged(req, &w)
defer logger.Log()
// Dispatch to the internal handler