github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-31 23:37:01 +00:00
Code Issues Projects Releases Wiki Activity

TestGetPodsToDelete: Use field names in test cases

Browse Source 
* pkg/controller/replicaset/replica_set_test.go (TestGetPodsToDelete): Use
explicit field names in declarations of test cases.
This commit is contained in:
Miciah Masters 2019-09-16 21:51:23 -04:00 committed by Miciah Dashiel Butler Masters
parent fef819254a
commit 865c3c5670
1 changed files with 32 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
pkg/controller/replicaset/replica_set_test.go
View File

@ -1468,39 +1468,39 @@ func TestGetPodsToDelete(t *testing.T) {
// a scheduled, running, ready pod
// Note that a pending pod cannot be ready
{
"len(pods) = 0 (i.e., diff = 0 too)",
[]*v1.Pod{},
0,
[]*v1.Pod{},
name: "len(pods) = 0 (i.e., diff = 0 too)",
pods: []*v1.Pod{},
diff: 0,
expectedPodsToDelete: []*v1.Pod{},
},
{
"diff = len(pods)",
[]*v1.Pod{
name: "diff = len(pods)",
pods: []*v1.Pod{
scheduledRunningNotReadyPod,
scheduledRunningReadyPod,
},
2,
[]*v1.Pod{scheduledRunningNotReadyPod, scheduledRunningReadyPod},
diff: 2,
expectedPodsToDelete: []*v1.Pod{scheduledRunningNotReadyPod, scheduledRunningReadyPod},
},
{
"diff < len(pods)",
[]*v1.Pod{
name: "diff < len(pods)",
pods: []*v1.Pod{
scheduledRunningReadyPod,
scheduledRunningNotReadyPod,
},
1,
[]*v1.Pod{scheduledRunningNotReadyPod},
diff: 1,
expectedPodsToDelete: []*v1.Pod{scheduledRunningNotReadyPod},
},
{
"various pod phases and conditions, diff = len(pods)",
[]*v1.Pod{
name: "various pod phases and conditions, diff = len(pods)",
pods: []*v1.Pod{
scheduledRunningReadyPod,
scheduledRunningNotReadyPod,
scheduledPendingPod,
unscheduledPendingPod,
},
4,
[]*v1.Pod{
diff: 4,
expectedPodsToDelete: []*v1.Pod{
scheduledRunningReadyPod,
scheduledRunningNotReadyPod,
scheduledPendingPod,
@ -1508,50 +1508,50 @@ func TestGetPodsToDelete(t *testing.T) {
},
},
{
"scheduled vs unscheduled, diff < len(pods)",
[]*v1.Pod{
name: "scheduled vs unscheduled, diff < len(pods)",
pods: []*v1.Pod{
scheduledPendingPod,
unscheduledPendingPod,
},
1,
[]*v1.Pod{
diff: 1,
expectedPodsToDelete: []*v1.Pod{
unscheduledPendingPod,
},
},
{
"ready vs not-ready, diff < len(pods)",
[]*v1.Pod{
name: "ready vs not-ready, diff < len(pods)",
pods: []*v1.Pod{
scheduledRunningReadyPod,
scheduledRunningNotReadyPod,
scheduledRunningNotReadyPod,
},
2,
[]*v1.Pod{
diff: 2,
expectedPodsToDelete: []*v1.Pod{
scheduledRunningNotReadyPod,
scheduledRunningNotReadyPod,
},
},
{
"pending vs running, diff < len(pods)",
[]*v1.Pod{
name: "pending vs running, diff < len(pods)",
pods: []*v1.Pod{
scheduledPendingPod,
scheduledRunningNotReadyPod,
},
1,
[]*v1.Pod{
diff: 1,
expectedPodsToDelete: []*v1.Pod{
scheduledPendingPod,
},
},
{
"various pod phases and conditions, diff < len(pods)",
[]*v1.Pod{
name: "various pod phases and conditions, diff < len(pods)",
pods: []*v1.Pod{
scheduledRunningReadyPod,
scheduledRunningNotReadyPod,
scheduledPendingPod,
unscheduledPendingPod,
},
3,
[]*v1.Pod{
diff: 3,
expectedPodsToDelete: []*v1.Pod{
unscheduledPendingPod,
scheduledPendingPod,
scheduledRunningNotReadyPod,