github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-19 01:40:13 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #110745 from AllenZMC/improve_printers

Browse Source 
Check for errors ahead of time
This commit is contained in:
Kubernetes Prow Robot 2022-06-28 08:03:58 -07:00 committed by GitHub
commit 8f755aad55
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/printers/tablegenerator_test.go
View File

@ -51,7 +51,10 @@ func ErrorPrintHandler(obj *TestPrintType, options GenerateOptions) ([]metav1bet
func TestCustomTypePrinting(t *testing.T) {
columns := []metav1beta1.TableColumnDefinition{{Name: "Data"}}
generator := NewTableGenerator()
generator.TableHandler(columns, PrintCustomType)
err := generator.TableHandler(columns, PrintCustomType)
if err != nil {
t.Fatalf("An error occurred when adds a print handler with a given set of columns: %#v", err)
}
obj := TestPrintType{"test object"}
table, err := generator.GenerateTable(&obj, GenerateOptions{})
@ -71,9 +74,13 @@ func TestCustomTypePrinting(t *testing.T) {
func TestPrintHandlerError(t *testing.T) {
columns := []metav1beta1.TableColumnDefinition{{Name: "Data"}}
generator := NewTableGenerator()
generator.TableHandler(columns, ErrorPrintHandler)
err := generator.TableHandler(columns, ErrorPrintHandler)
if err != nil {
t.Fatalf("An error occurred when adds a print handler with a given set of columns: %#v", err)
}
obj := TestPrintType{"test object"}
_, err := generator.GenerateTable(&obj, GenerateOptions{})
_, err = generator.GenerateTable(&obj, GenerateOptions{})
if err == nil || err.Error() != "ErrorPrintHandler error" {
t.Errorf("Did not get the expected error: %#v", err)
}