mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-22 19:31:44 +00:00
Merge pull request #109601 from shiftstack/dirty_service
Prevent dirty service object leaking between reconciles
This commit is contained in:
commit
914406da51
@ -887,7 +887,10 @@ func (s *Controller) syncService(ctx context.Context, key string) error {
|
||||
case err != nil:
|
||||
runtime.HandleError(fmt.Errorf("Unable to retrieve service %v from store: %v", key, err))
|
||||
default:
|
||||
err = s.processServiceCreateOrUpdate(ctx, service, key)
|
||||
// It is not safe to modify an object returned from an informer.
|
||||
// As reconcilers may modify the service object we need to copy
|
||||
// it first.
|
||||
err = s.processServiceCreateOrUpdate(ctx, service.DeepCopy(), key)
|
||||
}
|
||||
|
||||
return err
|
||||
|
Loading…
Reference in New Issue
Block a user