github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 22:46:12 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #109601 from shiftstack/dirty_service

Browse Source 
Prevent dirty service object leaking between reconciles
This commit is contained in:
Kubernetes Prow Robot 2022-07-27 18:15:10 -07:00 committed by GitHub
commit 914406da51
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
staging/src/k8s.io/cloud-provider/controllers/service/controller.go
View File

@ -887,7 +887,10 @@ func (s *Controller) syncService(ctx context.Context, key string) error {
case err != nil:
runtime.HandleError(fmt.Errorf("Unable to retrieve service %v from store: %v", key, err))
default:
err = s.processServiceCreateOrUpdate(ctx, service, key)
// It is not safe to modify an object returned from an informer.
// As reconcilers may modify the service object we need to copy
// it first.
err = s.processServiceCreateOrUpdate(ctx, service.DeepCopy(), key)
}
return err