github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-09 12:07:47 +00:00
Code Issues Projects Releases Wiki Activity

apiserver/storage/cacher: decrease of running time of TestEmptyWatchEventCache

Browse Source 
updates the test to wait 300 ms instead of 3s
the watch was established otherwise
we would be blocking on a call to cache.Watch(...)
in addition to that, the tests are serial in nature,
meaning that there is no other actor
that could add items to the database,
which could result in receiving new items.

Before:
go test -race  -run TestEmptyWatchEventCache
ok  	k8s.io/apiserver/pkg/storage/cacher	8.450s

After:
go test -race  -run TestEmptyWatchEventCache
ok  	k8s.io/apiserver/pkg/storage/cacher	2.635s
This commit is contained in:
Lukasz Szaszkiewicz 2024-03-12 13:34:04 +01:00
parent 3ec6a38795
commit 926122c035
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
staging/src/k8s.io/apiserver/pkg/storage/cacher/cacher_whitebox_test.go
View File

@ -431,7 +431,14 @@ func TestEmptyWatchEventCache(t *testing.T) {
if e, a := tt.expectedEvent.Object, event.Object; !apiequality.Semantic.DeepDerivative(e, a) {
t.Errorf("Expected: %#v, got: %#v", e, a)
}
case <-time.After(3 * time.Second):
case <-time.After(1 * time.Second):
// the watch was established otherwise
// we would be blocking on cache.Watch(...)
// in addition to that, the tests are serial in nature,
// meaning that there is no other actor
// that could add items to the database,
// which could result in receiving new items.
// given that waiting 1s seems okay
if tt.expectedEvent != nil {
t.Errorf("Failed to get an event")
}