github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-24 04:06:03 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #114033 from Octopusjust/k8s-pr14

Browse Source 
pkg/controller/deployment/util/deployment_util.go:Improving test cove…
This commit is contained in:
Kubernetes Prow Robot 2022-12-10 06:03:55 -08:00 committed by GitHub
commit 92ffe94592
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 79 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

79
pkg/controller/deployment/util/deployment_util_test.go
View File

@ -35,6 +35,7 @@ import (
"k8s.io/client-go/informers"
"k8s.io/client-go/kubernetes/fake"
"k8s.io/kubernetes/pkg/controller"
"k8s.io/utils/pointer"
)
func newDControllerRef(d *apps.Deployment) *metav1.OwnerReference {
@ -1248,3 +1249,81 @@ func TestGetDeploymentsForReplicaSet(t *testing.T) {
}
}
func TestMinAvailable(t *testing.T) {
maxSurge := func(i int) *intstr.IntOrString { x := intstr.FromInt(i); return &x }(int(1))
deployment := func(replicas int32, maxUnavailable intstr.IntOrString) *apps.Deployment {
return &apps.Deployment{
Spec: apps.DeploymentSpec{
Replicas: pointer.Int32(replicas),
Strategy: apps.DeploymentStrategy{
RollingUpdate: &apps.RollingUpdateDeployment{
MaxSurge: maxSurge,
MaxUnavailable: &maxUnavailable,
},
Type: apps.RollingUpdateDeploymentStrategyType,
},
},
}
}
tests := []struct {
name string
deployment *apps.Deployment
expected int32
}{
{
name: "replicas greater than maxUnavailable",
deployment: deployment(10, intstr.FromInt(5)),
expected: 5,
},
{
name: "replicas equal maxUnavailable",
deployment: deployment(10, intstr.FromInt(10)),
expected: 0,
},
{
name: "replicas less than maxUnavailable",
deployment: deployment(5, intstr.FromInt(10)),
expected: 0,
},
{
name: "replicas is 0",
deployment: deployment(0, intstr.FromInt(10)),
expected: 0,
},
{
name: "minAvailable with Recreate deployment strategy",
deployment: &apps.Deployment{
Spec: apps.DeploymentSpec{
Replicas: pointer.Int32(10),
Strategy: apps.DeploymentStrategy{
Type: apps.RecreateDeploymentStrategyType,
},
},
},
expected: 0,
},
{
name: "replicas greater than maxUnavailable with percents",
deployment: deployment(10, intstr.FromString("60%")),
expected: 4,
},
{
name: "replicas equal maxUnavailable with percents",
deployment: deployment(10, intstr.FromString("100%")),
expected: int32(0),
},
{
name: "replicas less than maxUnavailable with percents",
deployment: deployment(5, intstr.FromString("100%")),
expected: 0,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := MinAvailable(tt.deployment); got != tt.expected {
t.Errorf("MinAvailable() = %v, want %v", got, tt.expected)
}
})
}
}