github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 22:46:12 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #126030 from kaisoz/test-SuccessPolicyMet-false-ignored

Browse Source 
job_controller: Add test for SuccessCriteriaMet=False
This commit is contained in:
Kubernetes Prow Robot 2024-07-11 09:24:04 -07:00 committed by GitHub
commit 9356b0e3e9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
pkg/controller/job/job_controller_test.go
View File

@ -291,6 +291,7 @@ func TestControllerSyncJob(t *testing.T) {
podIndexLabelDisabled bool podIndexLabelDisabled bool
jobPodReplacementPolicy bool jobPodReplacementPolicy bool
jobPodFailurePolicy bool jobPodFailurePolicy bool
jobSuccessPolicy bool
}{ }{
"job start": { "job start": {
parallelism: 2, parallelism: 2,
@ -1187,6 +1188,38 @@ func TestControllerSyncJob(t *testing.T) {
}, },
}, },
}, },
"SuccessCriteriaMet=False condition added manually is ignored": {
jobSuccessPolicy: true,
parallelism: 1,
completions: 1,
activePods: 1,
readyPods: 1,
initialStatus: &jobInitialStatus{
active: 1,
startTime: func() *time.Time {
now := time.Now()
return &now
}(),
conditions: []batch.JobCondition{
{
Type: batch.JobSuccessCriteriaMet,
Status: v1.ConditionFalse,
Reason: "ConditionAddedManually",
Message: "Testing",
},
},
},
expectedActive: 1,
expectedReady: ptr.To[int32](1),
expectedConditions: []batch.JobCondition{
{
Type: batch.JobSuccessCriteriaMet,
Status: v1.ConditionFalse,
Reason: "ConditionAddedManually",
Message: "Testing",
},
},
},
} }
for name, tc := range testCases { for name, tc := range testCases {
@ -1195,6 +1228,7 @@ func TestControllerSyncJob(t *testing.T) {
featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.PodIndexLabel, !tc.podIndexLabelDisabled) featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.PodIndexLabel, !tc.podIndexLabelDisabled)
featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.JobPodReplacementPolicy, tc.jobPodReplacementPolicy) featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.JobPodReplacementPolicy, tc.jobPodReplacementPolicy)
featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.JobPodFailurePolicy, tc.jobPodFailurePolicy) featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.JobPodFailurePolicy, tc.jobPodFailurePolicy)
featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, features.JobSuccessPolicy, tc.jobSuccessPolicy)
// job manager setup // job manager setup
clientSet := clientset.NewForConfigOrDie(&restclient.Config{Host: "", ContentConfig: restclient.ContentConfig{GroupVersion: &schema.GroupVersion{Group: "", Version: "v1"}}}) clientSet := clientset.NewForConfigOrDie(&restclient.Config{Host: "", ContentConfig: restclient.ContentConfig{GroupVersion: &schema.GroupVersion{Group: "", Version: "v1"}}})