github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-24 12:15:52 +00:00
Code Issues Projects Releases Wiki Activity

Remove redundant code in kubectl top pod (#99062)

Browse Source 
* Update top_pod.go

* Update top_pod.go
This commit is contained in:
Heng WU 2021-02-17 11:17:06 -06:00 committed by GitHub
parent 4f1dd5d2fb
commit 93ab4e96f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
staging/src/k8s.io/kubectl/pkg/cmd/top/top_pod.go
View File

@ -183,9 +183,9 @@ func (o TopPodOptions) RunTopPod() error {
if len(metrics.Items) == 0 {
// If the API server query is successful but all the pods are newly created,
// the metrics are probably not ready yet, so we return the error here in the first place.
e := verifyEmptyMetrics(o, selector)
if e != nil {
return e
err := verifyEmptyMetrics(o, selector)
if err != nil {
return err
}
// if we had no errors, be sure we output something.
@ -195,9 +195,6 @@ func (o TopPodOptions) RunTopPod() error {
fmt.Fprintf(o.ErrOut, "No resources found in %s namespace.\n", o.Namespace)
}
}
if err != nil {
return err
}
return o.Printer.PrintPodMetrics(metrics.Items, o.PrintContainers, o.AllNamespaces, o.NoHeaders, o.SortBy)
}