[Federation] Review comment fixes for making federation etcd PVC size configurable

federation/pkg/kubefed/init/init.go

@@ -356,7 +356,6 @@ func createControllerManagerKubeconfigSecret(clientset *client.Clientset, namesp
 }
 
 func createPVC(clientset *client.Clientset, namespace, svcName, etcdPVCapacity string) (*api.PersistentVolumeClaim, error) {
-
 	capacity, err := resource.ParseQuantity(etcdPVCapacity)
 	if err != nil {
 		return nil, err

federation/pkg/kubefed/init/init_test.go

@@ -403,12 +403,9 @@ func fakeInitHostFactory(federationName, namespaceName, ip, dnsZoneName, image,
 	svcUrlPrefix := "/api/v1/namespaces/federation-system/services"
 	credSecretName := svcName + "-credentials"
 	cmKubeconfigSecretName := federationName + "-controller-manager-kubeconfig"
-	pvCap := ""
-
-	if "" != etcdPVCapacity {
+	pvCap := "10Gi"
+	if etcdPVCapacity != "" {
 		pvCap = etcdPVCapacity
-	} else {
-		pvCap = "10Gi" //test for default value
 	}
 
 	capacity, err := resource.ParseQuantity(pvCap)

hack/verify-flags/known-flags.txt

@@ -169,6 +169,7 @@ etcd-config
 etcd-keyfile
 etcd-mutation-timeout
 etcd-prefix
+etcd-pv-capacity
 etcd-quorum-read
 etcd-server
 etcd-servers